leverage ITuple interface #1733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merge conflict resolved |
SimonCropp
commented
Aug 26, 2022
| @@ -396,13 +396,17 @@ public void AllTupleLengthsUpToSevenAreSupportedForCapturing() | |||
| Assert.IsType<SequenceValue>(_converter.CreatePropertyValue(t)); | |||
| } | |||
|
|
|||
| #if !IVALUETUPLE | |||
|
|
|||
| [Fact] | |||
| public void EightPlusValueTupleElementsAreIgnoredByCapturing() | |||
There was a problem hiding this comment.
i wasnt sure if 8 was a by design choice? or u just didnt want to bloat the conversion code with too many tuple conversions.
if it is by design, let me know and i will make the ITuple respect this
There was a problem hiding this comment.
Not by design - I think dropping this limitation is good 👍
|
@nblumhardt thoughts on this on? |
|
LGTM! |
Merged
Twinki14
pushed a commit
to Twinki14/CitizenFX.Extensions.Client.Serilog
that referenced
this pull request
Dec 30, 2023
* leverage ITuple interface * IVALUETUPLE * resolve merge conflict * missed a conflict * const should be ITUPLE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.