2.11.0 Release #1614
Merged
2.11.0 Release #1614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make some local functions static to avoid scope capture * make some local functions static
"...event when..." -> "...even when..."
* add nullable for ilogger and implementations * narrow down nullables * make ILogEventEnricher not null
* make tests nullable * Update MessageTemplateTextFormatterTests.cs * Update MessageTemplateTextFormatterTests.cs * remove some } = null!; * Update LogContextTests.cs * missing log events * Update DelegatingSink.cs
…tidy accordingly (#1596)
* fixed exception * added unit test and using comma as seperator * added empty array return * removed internal * added support for int[] support * support any collection type * Remove unnecessary newline Co-authored-by: Tomasz Stochmal <tomasz.stochmal@iress.com> Co-authored-by: Nicholas Blumhardt <nblumhardt@nblumhardt.com>
* Update PropertyBinder.cs * Update LoggerConfiguration.cs * Update AggregateSink.cs * Update ConditionalSink.cs * Update DisposeDelegatingSink.cs * Update DisposingAggregateSink.cs * Update FilteringSink.cs * Update RestrictedSink.cs * Update SafeAggregateSink.cs * Update SecondaryLoggerSink.cs * Update LoggingLevelSwitch.cs * Update PropertiesOutputFormat.cs * Update JsonFormatter.cs * Update JsonValueFormatterTests.cs * Update Log.cs
…ings with array values)
…erter.GetProperties()
The example in the documentation was using a wrong name for the attribute. Corrected the usage in the example
- Update ILogger examples XML documentation to use `<code>` - Fix an errant `>`
This reverts commit 5de7002.
|
If you're able to try out |
|
works on my machine |
bartelink
reviewed
Apr 23, 2022
src/Serilog/ILogger.cs
Outdated
| /// MessageTemplate template; | ||
| /// IEnumerable<LogEventProperty> properties; | ||
| /// IEnumerable<LogEventProperty> properties>; |
There was a problem hiding this comment.
this line does not look right (have not checked rest in detail)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
staticto avoid scope capture (@SimonCropp)string[]to key-value settings #1561 - add support for collections/string[]to key-value settings (@stochmal)net5.0target (@nblumhardt)MessageTemplateFormatMethod(@JinsPeter)Memory<T>/ReadOnlyMemory<T>and non-reflection-compatible properties e.g. of typeSpan<T>(@skomis-mm)ILoggerdocumentation (@erichiller)