-
Notifications
You must be signed in to change notification settings - Fork 831
Add support for collections/string[]
to key-value settings
#1561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for collections/string[]
to key-value settings
#1561
Conversation
Thanks Tomasz! Initial thoughts -
|
I need this fix for company project I am working on. Lets see what I can change. |
Any thoughts on:
Would seem to make this a more well-rounded addition. |
Hi @stochmal - still interested in pushing this forward? |
string[]
to key-value settings
yes need this fix as it's broken in .NET Framework (works fine in .NET Core) |
tags are set in config file so it's always string to string[] conversion so don't see any use case for other array type |
this entry in App.config is crashing Serilog
|
Configuration method args can be any type; if a sink takes |
Awesome, thanks @stochmal ! Looks good to me, too - should have this in today 👍 |
Nice, Thanks for your help. When will there be official release that contains that fix? |
I've just opened #1614 to track the next stable release; I'll add more details there as we figure out the schedule 👍 |
…#1561) * fixed exception * added unit test and using comma as seperator * added empty array return * removed internal * added support for int[] support * support any collection type * Remove unnecessary newline Co-authored-by: Tomasz Stochmal <tomasz.stochmal@iress.com> Co-authored-by: Nicholas Blumhardt <nblumhardt@nblumhardt.com>
#1560