-
Notifications
You must be signed in to change notification settings - Fork 829
Closed
Description
Minor nits from perusing the source; most are likely breaking changes best kept for v4
- TFMs
- maybe a note somewhere about having a
net6.0
TFM but explaining that no egregious later ones will be added see (see reasoning in Add net6.0 Target serilog-sinks-console#145 (comment)) - remove net5.0 TFM (see above)
- remove
net7.0
TFM (atm it has identical DefineConstants values tonet6.0
) - Remove netcoreapp3.1, net5.0 from tests
- maybe a note somewhere about having a
- README
-
Is there a stance/policy on copyright years (atm readme has 2020)
-
var log = new LoggerConfiguration()
should gain ausing
-
Log.CloseAndFlush();
in static example- should probably gain
a
// Normally in atry/finally
; ensures File, Async etc sinks have been flushed before program exits` - or, more tersely '// ensure buffering or async Sinks are flushed before app exits'
- should probably gain
-
move gitter mention further down the list? or remove?
-
We welcome bug reports and suggestions through our
We welcome reproducable bug reports and detailed feature requests through our issue tracker here on GitHub; please note the other avenues are much better or for quick questions or seeking usage help
-
- 🤔 remove changes.md given it stops dead at 2.10 (or sync with GH release notes)
- AssemblyVersion [for 3.x] is
2.0
, maybe shift to 4.0 in v4? - on https://github.com/serilog/serilog/wiki/Getting-Started, in the sample app
- maybe lose
and Windows Phone 8+.
(maybe add some Blazor mention?) - use a top level
namespace SerilogExample
- consider using
await Log.CloseAndFlushAsync()
- (if this makes sense, ping me and I can do the edits)
- maybe lose
- 914M on https://www.nuget.org/packages/Serilog/ is insane (currently # 8 all time, should be 7 soon) - not long to go to 1B!
(Happy to do PRs for any that get agreed; equally happy for someone else to do them...)