Skip to content

refactor: Merge multiple FromStr visitors to a single FromStrVisitor #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 12, 2021
Merged

refactor: Merge multiple FromStr visitors to a single FromStrVisitor #1948

merged 2 commits into from
Jan 12, 2021

Conversation

Marwes
Copy link
Contributor

@Marwes Marwes commented Jan 12, 2021

Only refactors, doesn't actually expose this visitor

Markus Westerlind and others added 2 commits January 12, 2021 11:32
dtolnay
dtolnay approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 78a9dbc into serde-rs:master Jan 12, 2021
@Marwes Marwes deleted the from_str branch January 12, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marwes @dtolnay