-
-
Notifications
You must be signed in to change notification settings - Fork 853
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: serde-rs/serde
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.198
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: serde-rs/serde
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.199
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 4 commits
- 5 files changed
- 2 contributors
Commits on Apr 20, 2024
-
Ignore cast_precision_loss pedantic clippy lint
warning: casting `i32` to `f32` causes a loss of precision (`i32` is 32 bits wide, but `f32`'s mantissa is only 23 bits wide) --> serde/src/de/impls.rs:197:16 | 197 | Ok(v as Self::Value) | ^^^^^^^^^^^^^^^^ ... 457 | / impl_deserialize_num! { 458 | | f32, deserialize_f32 459 | | num_self!(f32:visit_f32); 460 | | num_as_copysign_self!(f64:visit_f64); 461 | | num_as_self!(i8:visit_i8 i16:visit_i16 i32:visit_i32 i64:visit_i64); 462 | | num_as_self!(u8:visit_u8 u16:visit_u16 u32:visit_u32 u64:visit_u64); 463 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_precision_loss = note: `-W clippy::cast-precision-loss` implied by `-W clippy::pedantic` = help: to override `-W clippy::pedantic` add `#[allow(clippy::cast_precision_loss)]` = note: this warning originates in the macro `num_as_self` which comes from the expansion of the macro `impl_deserialize_num` (in Nightly builds, run with -Z macro-backtrace for more info) warning: casting `i64` to `f32` causes a loss of precision (`i64` is 64 bits wide, but `f32`'s mantissa is only 23 bits wide) --> serde/src/de/impls.rs:197:16 | 197 | Ok(v as Self::Value) | ^^^^^^^^^^^^^^^^ ... 457 | / impl_deserialize_num! { 458 | | f32, deserialize_f32 459 | | num_self!(f32:visit_f32); 460 | | num_as_copysign_self!(f64:visit_f64); 461 | | num_as_self!(i8:visit_i8 i16:visit_i16 i32:visit_i32 i64:visit_i64); 462 | | num_as_self!(u8:visit_u8 u16:visit_u16 u32:visit_u32 u64:visit_u64); 463 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_precision_loss = note: this warning originates in the macro `num_as_self` which comes from the expansion of the macro `impl_deserialize_num` (in Nightly builds, run with -Z macro-backtrace for more info) warning: casting `u32` to `f32` causes a loss of precision (`u32` is 32 bits wide, but `f32`'s mantissa is only 23 bits wide) --> serde/src/de/impls.rs:197:16 | 197 | Ok(v as Self::Value) | ^^^^^^^^^^^^^^^^ ... 457 | / impl_deserialize_num! { 458 | | f32, deserialize_f32 459 | | num_self!(f32:visit_f32); 460 | | num_as_copysign_self!(f64:visit_f64); 461 | | num_as_self!(i8:visit_i8 i16:visit_i16 i32:visit_i32 i64:visit_i64); 462 | | num_as_self!(u8:visit_u8 u16:visit_u16 u32:visit_u32 u64:visit_u64); 463 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_precision_loss = note: this warning originates in the macro `num_as_self` which comes from the expansion of the macro `impl_deserialize_num` (in Nightly builds, run with -Z macro-backtrace for more info) warning: casting `u64` to `f32` causes a loss of precision (`u64` is 64 bits wide, but `f32`'s mantissa is only 23 bits wide) --> serde/src/de/impls.rs:197:16 | 197 | Ok(v as Self::Value) | ^^^^^^^^^^^^^^^^ ... 457 | / impl_deserialize_num! { 458 | | f32, deserialize_f32 459 | | num_self!(f32:visit_f32); 460 | | num_as_copysign_self!(f64:visit_f64); 461 | | num_as_self!(i8:visit_i8 i16:visit_i16 i32:visit_i32 i64:visit_i64); 462 | | num_as_self!(u8:visit_u8 u16:visit_u16 u32:visit_u32 u64:visit_u64); 463 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_precision_loss = note: this warning originates in the macro `num_as_self` which comes from the expansion of the macro `impl_deserialize_num` (in Nightly builds, run with -Z macro-backtrace for more info) warning: casting `i64` to `f64` causes a loss of precision (`i64` is 64 bits wide, but `f64`'s mantissa is only 52 bits wide) --> serde/src/de/impls.rs:197:16 | 197 | Ok(v as Self::Value) | ^^^^^^^^^^^^^^^^ ... 465 | / impl_deserialize_num! { 466 | | f64, deserialize_f64 467 | | num_self!(f64:visit_f64); 468 | | num_as_copysign_self!(f32:visit_f32); 469 | | num_as_self!(i8:visit_i8 i16:visit_i16 i32:visit_i32 i64:visit_i64); 470 | | num_as_self!(u8:visit_u8 u16:visit_u16 u32:visit_u32 u64:visit_u64); 471 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_precision_loss = note: this warning originates in the macro `num_as_self` which comes from the expansion of the macro `impl_deserialize_num` (in Nightly builds, run with -Z macro-backtrace for more info) warning: casting `u64` to `f64` causes a loss of precision (`u64` is 64 bits wide, but `f64`'s mantissa is only 52 bits wide) --> serde/src/de/impls.rs:197:16 | 197 | Ok(v as Self::Value) | ^^^^^^^^^^^^^^^^ ... 465 | / impl_deserialize_num! { 466 | | f64, deserialize_f64 467 | | num_self!(f64:visit_f64); 468 | | num_as_copysign_self!(f32:visit_f32); 469 | | num_as_self!(i8:visit_i8 i16:visit_i16 i32:visit_i32 i64:visit_i64); 470 | | num_as_self!(u8:visit_u8 u16:visit_u16 u32:visit_u32 u64:visit_u64); 471 | | } | |_- in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_precision_loss = note: this warning originates in the macro `num_as_self` which comes from the expansion of the macro `impl_deserialize_num` (in Nightly builds, run with -Z macro-backtrace for more info)
Configuration menu - View commit details
-
Copy full SHA for f6623a3 - Browse repository at this point
Copy the full SHA f6623a3View commit details
Commits on Apr 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8fe7539 - Browse repository at this point
Copy the full SHA 8fe7539View commit details
Commits on Apr 27, 2024
-
Merge pull request #2732 from aatifsyed/master
fix: ambiguous associated item in forward_to_deserialize_any!
Configuration menu - View commit details
-
Copy full SHA for 789740b - Browse repository at this point
Copy the full SHA 789740bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1477028 - Browse repository at this point
Copy the full SHA 1477028View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.198...v1.0.199