-
-
Notifications
You must be signed in to change notification settings - Fork 854
Comparing changes
Open a pull request
base repository: serde-rs/serde
base: v1.0.156
head repository: serde-rs/serde
compare: v1.0.159
- 20 commits
- 25 files changed
- 1 contributor
Commits on Mar 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c0296ee - Browse repository at this point
Copy the full SHA c0296eeView commit details
Commits on Mar 18, 2023
-
Merge pull request #2404 from dtolnay/attributeexpr
Add ui test of malformed attribute containing expression
Configuration menu - View commit details
-
Copy full SHA for 9d87851 - Browse repository at this point
Copy the full SHA 9d87851View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32f0d00 - Browse repository at this point
Copy the full SHA 32f0d00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b23634 - Browse repository at this point
Copy the full SHA 5b23634View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0509810 - Browse repository at this point
Copy the full SHA 0509810View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc22641 - Browse repository at this point
Copy the full SHA bc22641View commit details -
Merge pull request #2406 from dtolnay/nestedmeta
Rewrite attribute parser using parse_nested_meta
Configuration menu - View commit details
-
Copy full SHA for 9fc0d13 - Browse repository at this point
Copy the full SHA 9fc0d13View commit details -
Ignore single_match_else pedantic clippy lint in serde_derive_internals
error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> serde_derive_internals/src/attr.rs:1412:8 | 1412 | Ok(match string.parse() { | ________^ 1413 | | Ok(path) => Some(path), 1414 | | Err(_) => { 1415 | | cx.error_spanned_by( ... | 1420 | | } 1421 | | }) | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match_else = note: `-D clippy::single-match-else` implied by `-D clippy::pedantic` help: try this | 1412 ~ Ok(if let Ok(path) = string.parse() { Some(path) } else { 1413 + cx.error_spanned_by( 1414 + &string, 1415 + format!("failed to parse path: {:?}", string.value()), 1416 + ); 1417 + None 1418 ~ }) | error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> serde_derive_internals/src/attr.rs:1434:8 | 1434 | Ok(match string.parse() { | ________^ 1435 | | Ok(expr) => Some(expr), 1436 | | Err(_) => { 1437 | | cx.error_spanned_by( ... | 1442 | | } 1443 | | }) | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match_else help: try this | 1434 ~ Ok(if let Ok(expr) = string.parse() { Some(expr) } else { 1435 + cx.error_spanned_by( 1436 + &string, 1437 + format!("failed to parse path: {:?}", string.value()), 1438 + ); 1439 + None 1440 ~ }) | error: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> serde_derive_internals/src/attr.rs:1478:8 | 1478 | Ok(match string.parse() { | ________^ 1479 | | Ok(ty) => Some(ty), 1480 | | Err(_) => { 1481 | | cx.error_spanned_by( ... | 1486 | | } 1487 | | }) | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match_else help: try this | 1478 ~ Ok(if let Ok(ty) = string.parse() { Some(ty) } else { 1479 + cx.error_spanned_by( 1480 + &string, 1481 + format!("failed to parse type: {} = {:?}", attr_name, string.value()), 1482 + ); 1483 + None 1484 ~ }) |
Configuration menu - View commit details
-
Copy full SHA for 5b8e065 - Browse repository at this point
Copy the full SHA 5b8e065View commit details -
Configuration menu - View commit details
-
Copy full SHA for c42e7c8 - Browse repository at this point
Copy the full SHA c42e7c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 479a00a - Browse repository at this point
Copy the full SHA 479a00aView commit details
Commits on Mar 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c3d637f - Browse repository at this point
Copy the full SHA c3d637fView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd460f8 - Browse repository at this point
Copy the full SHA dd460f8View commit details -
Merge pull request #2410 from serde-rs/attrvalue
Check for None-delimited group in attribute value
Configuration menu - View commit details
-
Copy full SHA for 2c0999a - Browse repository at this point
Copy the full SHA 2c0999aView commit details -
Reformat comments of non-public serde_derive internals
Fixes these being treated as "tests" by `cargo test` in serde_derive: running 3 tests test src/internals/check.rs - internals::check::check_remote_generic (line 23) ... FAILED test src/internals/check.rs - internals::check::check_remote_generic (line 29) ... FAILED test src/lib.rs - (line 3) ... ok failures: ---- src/internals/check.rs - internals::check::check_remote_generic (line 23) stdout ---- error: unknown start of token: \u{2026} --> src/internals/check.rs:25:20 | 4 | struct Generic<T> {…} | ^ error: cannot find attribute `serde` in this scope --> src/internals/check.rs:24:3 | 3 | #[serde(remote = "Generic")] | ^^^^^ | = note: `serde` is in scope, but it is a crate, not an attribute error[E0392]: parameter `T` is never used --> src/internals/check.rs:25:16 | 4 | struct Generic<T> {…} | ^ unused parameter | = help: consider removing `T`, referring to it in a field, or using a marker such as `PhantomData` = help: if you intended `T` to be a const parameter, use `const T: usize` instead ---- src/internals/check.rs - internals::check::check_remote_generic (line 29) stdout ---- error: unknown start of token: \u{2026} --> src/internals/check.rs:31:21 | 4 | struct ConcreteDef {…} | ^ error: cannot find attribute `serde` in this scope --> src/internals/check.rs:30:3 | 3 | #[serde(remote = "Generic<T>")] | ^^^^^ | = note: `serde` is in scope, but it is a crate, not an attribute
Configuration menu - View commit details
-
Copy full SHA for dc200a6 - Browse repository at this point
Copy the full SHA dc200a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e305810 - Browse repository at this point
Copy the full SHA e305810View commit details -
Configuration menu - View commit details
-
Copy full SHA for acfd19c - Browse repository at this point
Copy the full SHA acfd19cView commit details
Commits on Mar 28, 2023
-
Add regression test for issue 2415
Currently fails: error: unexpected end of input, unexpected token in nested attribute, expected ident --> test_suite/tests/regression/issue2415.rs:4:9 | 4 | #[serde()] | ^
Configuration menu - View commit details
-
Copy full SHA for 6ab55a1 - Browse repository at this point
Copy the full SHA 6ab55a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cb8d07 - Browse repository at this point
Copy the full SHA 4cb8d07View commit details -
Merge pull request #2422 from dtolnay/emptyattr
Accept empty #[serde()] attribute
Configuration menu - View commit details
-
Copy full SHA for 04af322 - Browse repository at this point
Copy the full SHA 04af322View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6de911 - Browse repository at this point
Copy the full SHA d6de911View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.156...v1.0.159