-
Notifications
You must be signed in to change notification settings - Fork 603
Comparing changes
Open a pull request
base repository: serde-rs/json
base: v1.0.132
head repository: serde-rs/json
compare: v1.0.133
- 11 commits
- 13 files changed
- 2 contributors
Commits on Oct 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 42ab31f - Browse repository at this point
Copy the full SHA 42ab31fView commit details
Commits on Nov 5, 2024
-
Raise minimum version for preserve_order feature to Rust 1.65
Required by hashbrown 0.15.1. error: package `hashbrown v0.15.1` cannot be built because it requires rustc 1.65.0 or newer, while the currently active rustc version is 1.64.0
Configuration menu - View commit details
-
Copy full SHA for 7cce517 - Browse repository at this point
Copy the full SHA 7cce517View commit details
Commits on Nov 9, 2024
-
Prevent upload-artifact step from causing CI failure
This step has been failing way more than reasonable across my various repos. With the provided path, there will be 1 file uploaded Artifact name is valid! Root directory input is valid! Attempt 1 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 3000 ms... Attempt 2 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 6029 ms... Attempt 3 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 8270 ms... Attempt 4 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 12577 ms... Error: Failed to CreateArtifact: Failed to make request after 5 attempts: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact
Configuration menu - View commit details
-
Copy full SHA for be2198a - Browse repository at this point
Copy the full SHA be2198aView commit details
Commits on Nov 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 73011c0 - Browse repository at this point
Copy the full SHA 73011c0View commit details
Commits on Nov 15, 2024
-
Merge pull request #1213 from djmitche/safety-comment
Add a safety comment to unsafe block
Configuration menu - View commit details
-
Copy full SHA for 75ed447 - Browse repository at this point
Copy the full SHA 75ed447View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07f280a - Browse repository at this point
Copy the full SHA 07f280aView commit details
Commits on Nov 16, 2024
-
Resolve unnecessary_map_or clippy lints
warning: this `map_or` is redundant --> src/value/partial_eq.rs:5:5 | 5 | value.as_i64().map_or(false, |i| i == other) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a standard comparison instead: `(value.as_i64() == Some(other))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `-W clippy::unnecessary-map-or` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_map_or)]` warning: this `map_or` is redundant --> src/value/partial_eq.rs:9:5 | 9 | value.as_u64().map_or(false, |i| i == other) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a standard comparison instead: `(value.as_u64() == Some(other))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or warning: this `map_or` is redundant --> src/value/partial_eq.rs:14:29 | 14 | Value::Number(n) => n.as_f32().map_or(false, |i| i == other), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a standard comparison instead: `(n.as_f32() == Some(other))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or warning: this `map_or` is redundant --> src/value/partial_eq.rs:20:5 | 20 | value.as_f64().map_or(false, |i| i == other) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a standard comparison instead: `(value.as_f64() == Some(other))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or warning: this `map_or` is redundant --> src/value/partial_eq.rs:24:5 | 24 | value.as_bool().map_or(false, |i| i == other) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a standard comparison instead: `(value.as_bool() == Some(other))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or warning: this `map_or` is redundant --> src/value/partial_eq.rs:28:5 | 28 | value.as_str().map_or(false, |i| i == other) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a standard comparison instead: `(value.as_str() == Some(other))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
Configuration menu - View commit details
-
Copy full SHA for a11f5f2 - Browse repository at this point
Copy the full SHA a11f5f2View commit details -
Disable question_mark clippy lint in lexical test
Serde_json uses #![deny(clippy::question_mark_used)]. warning: this `match` expression can be replaced with `?` --> tests/../src/lexical/algorithm.rs:54:21 | 54 | let value = match mantissa.checked_mul(power) { | _____________________^ 55 | | None => return None, 56 | | Some(value) => value, 57 | | }; | |_________^ help: try instead: `mantissa.checked_mul(power)?` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark = note: `-W clippy::question-mark` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::question_mark)]`
Configuration menu - View commit details
-
Copy full SHA for 2ccb5b6 - Browse repository at this point
Copy the full SHA 2ccb5b6View commit details
Commits on Nov 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4e5f985 - Browse repository at this point
Copy the full SHA 4e5f985View commit details -
Merge pull request #1215 from dtolnay/fromarray
Implement From<[T; N]> for Value
Configuration menu - View commit details
-
Copy full SHA for 2b65ca0 - Browse repository at this point
Copy the full SHA 2b65ca0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0903de4 - Browse repository at this point
Copy the full SHA 0903de4View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.132...v1.0.133