Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: serde-rs/json
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.132
Choose a base ref
...
head repository: serde-rs/json
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.133
Choose a head ref
  • 11 commits
  • 13 files changed
  • 2 contributors

Commits on Oct 31, 2024

  1. Configuration menu
    Copy the full SHA
    42ab31f View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Raise minimum version for preserve_order feature to Rust 1.65

    Required by hashbrown 0.15.1.
    
        error: package `hashbrown v0.15.1` cannot be built because it requires rustc 1.65.0 or newer, while the currently active rustc version is 1.64.0
    dtolnay committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    7cce517 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. Prevent upload-artifact step from causing CI failure

    This step has been failing way more than reasonable across my various repos.
    
        With the provided path, there will be 1 file uploaded
        Artifact name is valid!
        Root directory input is valid!
        Attempt 1 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 3000 ms...
        Attempt 2 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 6029 ms...
        Attempt 3 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 8270 ms...
        Attempt 4 of 5 failed with error: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact. Retrying request in 12577 ms...
        Error: Failed to CreateArtifact: Failed to make request after 5 attempts: Request timeout: /twirp/github.actions.results.api.v1.ArtifactService/CreateArtifact
    dtolnay committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    be2198a View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Configuration menu
    Copy the full SHA
    73011c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Merge pull request #1213 from djmitche/safety-comment

    Add a safety comment to unsafe block
    dtolnay authored Nov 15, 2024
    Configuration menu
    Copy the full SHA
    75ed447 View commit details
    Browse the repository at this point in the history
  2. Wrap PR 1213 to 80 columns

    dtolnay committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    07f280a View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. Resolve unnecessary_map_or clippy lints

        warning: this `map_or` is redundant
         --> src/value/partial_eq.rs:5:5
          |
        5 |     value.as_i64().map_or(false, |i| i == other)
          |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a standard comparison instead: `(value.as_i64() == Some(other))`
          |
          = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
          = note: `-W clippy::unnecessary-map-or` implied by `-W clippy::all`
          = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_map_or)]`
    
        warning: this `map_or` is redundant
         --> src/value/partial_eq.rs:9:5
          |
        9 |     value.as_u64().map_or(false, |i| i == other)
          |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a standard comparison instead: `(value.as_u64() == Some(other))`
          |
          = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
    
        warning: this `map_or` is redundant
          --> src/value/partial_eq.rs:14:29
           |
        14 |         Value::Number(n) => n.as_f32().map_or(false, |i| i == other),
           |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a standard comparison instead: `(n.as_f32() == Some(other))`
           |
           = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
    
        warning: this `map_or` is redundant
          --> src/value/partial_eq.rs:20:5
           |
        20 |     value.as_f64().map_or(false, |i| i == other)
           |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a standard comparison instead: `(value.as_f64() == Some(other))`
           |
           = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
    
        warning: this `map_or` is redundant
          --> src/value/partial_eq.rs:24:5
           |
        24 |     value.as_bool().map_or(false, |i| i == other)
           |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a standard comparison instead: `(value.as_bool() == Some(other))`
           |
           = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
    
        warning: this `map_or` is redundant
          --> src/value/partial_eq.rs:28:5
           |
        28 |     value.as_str().map_or(false, |i| i == other)
           |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use a standard comparison instead: `(value.as_str() == Some(other))`
           |
           = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
    dtolnay committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    a11f5f2 View commit details
    Browse the repository at this point in the history
  2. Disable question_mark clippy lint in lexical test

    Serde_json uses #![deny(clippy::question_mark_used)].
    
        warning: this `match` expression can be replaced with `?`
          --> tests/../src/lexical/algorithm.rs:54:21
           |
        54 |           let value = match mantissa.checked_mul(power) {
           |  _____________________^
        55 | |             None => return None,
        56 | |             Some(value) => value,
        57 | |         };
           | |_________^ help: try instead: `mantissa.checked_mul(power)?`
           |
           = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
           = note: `-W clippy::question-mark` implied by `-W clippy::all`
           = help: to override `-W clippy::all` add `#[allow(clippy::question_mark)]`
    dtolnay committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    2ccb5b6 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. Configuration menu
    Copy the full SHA
    4e5f985 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1215 from dtolnay/fromarray

    Implement From<[T; N]> for Value
    dtolnay authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    2b65ca0 View commit details
    Browse the repository at this point in the history
  3. Release 1.0.133

    dtolnay committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    0903de4 View commit details
    Browse the repository at this point in the history
Loading