Skip to content

Conversation

Dingsd4
Copy link

@Dingsd4 Dingsd4 commented Jul 3, 2025

This may resolve issue #204

@sensslen
Copy link
Owner

sensslen commented Jul 3, 2025

@Dingsd4 thank you for this Pull request. It's highly appreciated. I would love to see tests added for this. Would you mind working on this - I may not be able to work on that for a few days....

@Dingsd4
Copy link
Author

Dingsd4 commented Jul 3, 2025

Shall I patch your TableOutputFormatterTest to support the new setting printMarkdown (additional parameter at TestFixture) or do you prefer a MarkdownTableOutputFormatterTest

@sensslen
Copy link
Owner

sensslen commented Jul 3, 2025

Shall I patch your TableOutputFormatterTest to support the new setting printMarkdown (additional parameter at TestFixture) or do you prefer a MarkdownTableOutputFormatterTest

I'd prefer a new test class.... Up to you though - no hard feelings either way

Dingsd4 added 2 commits July 3, 2025 18:05
Verified using https://github.com/markdownlint/markdownlint
- exclude_rule 'MD013' - max line length 80 (terminal)
- exclude_rule 'MD057' - header separation fixed to triple minus - we use prettified output (multiple minus)
Copy link

sonarqubecloud bot commented Jul 3, 2025

@Dingsd4
Copy link
Author

Dingsd4 commented Jul 3, 2025

Done, code coverage of new code is at 100% with one exception.
I did not add test code for the (patched) unused Create function at TablePrinter.

public static TablePrinter Create(Stream stream, params string[] headings)
{
    return new TablePrinter(stream, headings, false);
}

@Dingsd4
Copy link
Author

Dingsd4 commented Jul 3, 2025

The sonarcubecloud code coverage (0%) has an error:

Coverage

A few extra steps are needed for SonarQube Cloud to analyze your code coverage.
Set up coverage analysis

@Dingsd4
Copy link
Author

Dingsd4 commented Jul 4, 2025

Depends on #207

@sensslen sensslen merged commit 27f2d03 into sensslen:main Jul 4, 2025
22 of 23 checks passed
@sensslen
Copy link
Owner

sensslen commented Jul 4, 2025

Thank you a lot for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants