-
-
Notifications
You must be signed in to change notification settings - Fork 18
Added support for output type: markdown #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Dingsd4 thank you for this Pull request. It's highly appreciated. I would love to see tests added for this. Would you mind working on this - I may not be able to work on that for a few days.... |
Shall I patch your TableOutputFormatterTest to support the new setting printMarkdown (additional parameter at TestFixture) or do you prefer a MarkdownTableOutputFormatterTest |
I'd prefer a new test class.... Up to you though - no hard feelings either way |
Verified using https://github.com/markdownlint/markdownlint - exclude_rule 'MD013' - max line length 80 (terminal) - exclude_rule 'MD057' - header separation fixed to triple minus - we use prettified output (multiple minus)
|
Done, code coverage of new code is at 100% with one exception. public static TablePrinter Create(Stream stream, params string[] headings)
{
return new TablePrinter(stream, headings, false);
} |
The sonarcubecloud code coverage (0%) has an error:
|
Depends on #207 |
Thank you a lot for this. |
This may resolve issue #204