Skip to content

Fix bootstrap3 select-width-item-border incompatible value #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2022
Merged

Fix bootstrap3 select-width-item-border incompatible value #1811

merged 1 commit into from
May 26, 2022

Conversation

nbluis
Copy link
Contributor

@nbluis nbluis commented May 25, 2022

The propose of the change is to solve a bug when we try to import the dist/selectize.bootstrap3.css using a CSS compiler like SASS.

The compiler throw an error of incompatible type in the calc function because we are trying to subtract a pixel value from a non defined value 0.

Error: 5px and 0 are incompatible.
  ╷
2 │       6px - 1px - 0
  │       ^^^^^^^^^^^^^
  ╵
  @selectize/selectize/dist/css/selectize.bootstrap3.css 2:7  @import

With this change, the result of this expressions will be like 6px - 1px - 0px instead of
6px - 1px - 0 making it compile correctly.

@risadams risadams merged commit 367bca7 into selectize:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@risadams risadams risadams approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbluis @risadams