-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
fix typo in ajax--url #5169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo in ajax--url #5169
Conversation
Looks like that was @NadeemAfana's commit so, we should ask him 😄 |
Can you provide a complete reproducible example where I can look at the source code ? |
@billyeh if you look at the Travis output, that might shed some light on the situation. |
Yeah, doesn't look like my fix was right. I pushed two branches of my project, with the only difference being the version of select2 installed. https://djattendance-405.herokuapp.com/accounts/login/?next=/accounts/switch You can login with user
|
I pushed a fix for this. There was an issue with parsing |
@billyeh does @NadeemAfana's commit solve the issue? If so, I will close this PR and reopen his. |
Yes, it looks good! Thank you guys for your help. Didn't realize we were so outdated on our jquery version. I deployed it again to https://djattendance-406.herokuapp.com/accounts/login/?next=/accounts/switch using that commit for |
…fferent jQuery versions
…fferent jQuery versions
…fferent jQuery versions
…fferent jQuery versions
Just going to re-open this until the old one is re-opened :) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request includes a
The following changes were made
Made a comment on the offending commit, a1dc7f2#r26352956
This seems to break custom ajax urls such as for django-select2 when used.
Version 4.0.5

Version 4.0.6-rc.1
