Skip to content

Conversation

billyeh
Copy link

@billyeh billyeh commented Dec 18, 2017

This pull request includes a

  • Bug fix
  • New feature
  • Translation

The following changes were made

  • Fixed a typo for data-ajax--url

Made a comment on the offending commit, a1dc7f2#r26352956

This seems to break custom ajax urls such as for django-select2 when used.

Version 4.0.5
4 0 5

Version 4.0.6-rc.1
4 0 6-rc 1

@alexweissman
Copy link
Contributor

Looks like that was @NadeemAfana's commit so, we should ask him 😄

@NadeemAfana
Copy link

Can you provide a complete reproducible example where I can look at the source code ?

@alexweissman
Copy link
Contributor

@billyeh if you look at the Travis output, that might shed some light on the situation.

@billyeh
Copy link
Author

billyeh commented Dec 20, 2017

Yeah, doesn't look like my fix was right.

I pushed two branches of my project, with the only difference being the version of select2 installed.

https://djattendance-405.herokuapp.com/accounts/login/?next=/accounts/switch
https://djattendance-406.herokuapp.com/accounts/login/?next=/accounts/switch

You can login with user admin@example.com and password admin

accounts/switch is a simple page using django_select2. Source code is at https://github.com/attendanceproject/djattendance

NadeemAfana pushed a commit to NadeemAfana/select2 that referenced this pull request Dec 21, 2017
NadeemAfana pushed a commit to NadeemAfana/select2 that referenced this pull request Dec 21, 2017
@NadeemAfana
Copy link

NadeemAfana commented Dec 21, 2017

I pushed a fix for this. There was an issue with parsing html5 data-* attributes between jQuery 1.x and 2.x. Let me know if you need a separate Pull Request.

@alexweissman
Copy link
Contributor

@billyeh does @NadeemAfana's commit solve the issue? If so, I will close this PR and reopen his.

@billyeh
Copy link
Author

billyeh commented Dec 22, 2017

Yes, it looks good! Thank you guys for your help. Didn't realize we were so outdated on our jquery version.

I deployed it again to https://djattendance-406.herokuapp.com/accounts/login/?next=/accounts/switch using that commit for select2 if you want to confirm.

@billyeh billyeh closed this Dec 22, 2017
NadeemAfana pushed a commit to NadeemAfana/select2 that referenced this pull request Dec 22, 2017
NadeemAfana pushed a commit to NadeemAfana/select2 that referenced this pull request Dec 22, 2017
NadeemAfana pushed a commit to NadeemAfana/select2 that referenced this pull request Dec 22, 2017
NadeemAfana pushed a commit to NadeemAfana/select2 that referenced this pull request Dec 22, 2017
@billyeh
Copy link
Author

billyeh commented Dec 23, 2017

Just going to re-open this until the old one is re-opened :)

@billyeh billyeh reopened this Dec 23, 2017
NadeemAfana pushed a commit to NadeemAfana/select2 that referenced this pull request Jan 2, 2018
NadeemAfana pushed a commit to NadeemAfana/select2 that referenced this pull request Jan 2, 2018
@stale
Copy link

stale bot commented Mar 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale label Mar 13, 2019
@stale stale bot closed this Mar 20, 2019
NadeemAfana pushed a commit to NadeemAfana/select2 that referenced this pull request Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants