Skip to content

Conversation

4rturj
Copy link
Contributor

@4rturj 4rturj commented Oct 26, 2020

This pull request includes a

  • Bug fix

The following changes were made

  • aria-controls attribute added for combobox

If this is related to an existing ticket, include a link to it as well.

@eckmo
Copy link

eckmo commented Feb 20, 2025

I believe that this fix does remove the "Element with role attribute has required states and properties" flag in a11y checkers, but should the id associated with aria-controls on the combobox instead be attached tot he corresponding listbox element? This MDN doc seems to suggest that's the correct use of aria-controls in the case of combobox. So in the case of this combobox, the id associated with the aria-controls would be select2-edit-field-topic-target-id-results instead of select2-edit-field-topic-target-id-container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants