Skip to content

Conversation

blikblum
Copy link
Contributor

@blikblum blikblum commented Jun 1, 2019

This pull request includes a

  • Bug fix
  • New feature
  • Translation
  • Dependency update

The following changes were made

  • Update most of the dev dependencies
  • grunt-contrib-qunit is not updated to latest version because it conflicts with almond. The newest version compatible with almond loader is 0.5. This avoids to update grunt
  • Update travis CI node version to 8 (oldest supported node)

This removes most of the build warnings / dependency vulnerabilities

@kevin-brown
Copy link
Member

  • grunt-contrib-qunit is not updated to latest version because it conflicts with almond

Do you happen to have a link to somewhere that states this? I believe you, I just didn't find anything when I did a quick search.

@blikblum
Copy link
Contributor Author

blikblum commented Jun 4, 2019

This is the affecting commit gruntjs/grunt-contrib-qunit@db075a2

The select2 loader will try to load qunit module and fail

@blikblum
Copy link
Contributor Author

blikblum commented Jun 4, 2019

Not a problem of almond at all, but a conflict between how the qunit-grunt runs and select2 loader

@kevin-brown kevin-brown mentioned this pull request Jun 5, 2019
4 tasks
@kevin-brown kevin-brown added this to the 4.0.8 milestone Jun 5, 2019
@kevin-brown
Copy link
Member

This was merged in through #5529. I recompiled the dist files there and double checked that the resulting files are compatible (they are).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants