Fix width becoming fixed to 0 if initialized when hidden by parent element #5502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Is there anything else that needs to be done? I realize that Travis is complaining about some lines being too long. If we are still interested in this patch, then I will invest effort to shorten those lines. |
kevin-brown
pushed a commit
that referenced
this pull request
Jul 9, 2019
This allows for more accurate resolution of the width when compared to the `resolve` method. This is more relevant for jQuery 1.x, where the `resolve` method cannot find the width of a hidden select box, but it also applies to newer versions of jQuery where the `width()` method provided by jQuery doesn't fully match `getComputedStyle()`. Fixes #3278 Fixes #5502 Closes #5259
3 tasks
kevin-brown
added a commit
that referenced
this pull request
Jul 9, 2019
This allows for more accurate resolution of the width when compared to the `resolve` method. This is more relevant for jQuery 1.x, where the `resolve` method cannot find the width of a hidden select box, but it also applies to newer versions of jQuery where the `width()` method provided by jQuery doesn't fully match `getComputedStyle()`. Fixes #3278 Fixes #5502 Closes #5259
MarnuLombard
added a commit
to Collivery/Collivery-WooCommerce
that referenced
this pull request
Sep 25, 2019
- The width of the `el` is collapsed if a parent is overlapping it. * See select2/select2#5502 - Use `width:'resolve'` so that the width of `el` matches the wrapper element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a
The following changes were made
If this is related to an existing ticket, include a link to it as well.
Related to #3292, #3817, #3278, #291, plus other duplicates.
Credit for the fix to resizeSearch() goes to @brandonhall of #3292.
I know that this may not give exactly the same result as when select2 is initialized while it is visible, but I really cannot tell what is a betterchoice than defaulting to 100% width. This is already 7 years old, so I hope it'll be fixed someday.
Between some offered solutions like #3292 and #4898, jQuery used to have a bug that resulted in width becoming 100px.
Originally posted by me in #3817:
As for test cases: I don't know how to test for this because it is faulty behaviour, not that the logic was wrong.
#5259 contains a test case that will exhibit this bug. You can refer to this fiddle as well: https://jsfiddle.net/NozomiTypeR/6pLzy1ak/44/