Skip to content

Revert PR #5356. #5492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2019
Merged

Revert PR #5356. #5492

merged 1 commit into from
May 1, 2019

Conversation

Ferroin
Copy link
Contributor

@Ferroin Ferroin commented Apr 30, 2019

This pull request includes a

  • Bug fix
  • New feature
  • Translation

The following changes were made

Fixes: #5490

Minimally tested (tests pass, and it appears to fix the single-select issue).

@Ferroin
Revert PR #5356.
4d3c134 
It doesn't really do what it says it does, and it introduces other
issues (single select elements re-open after selection).

Fixes: #5490
@kevin-brown kevin-brown merged commit 39bfabd into select2:develop May 1, 2019
@kevin-brown kevin-brown added this to the 4.0.7 milestone May 1, 2019
This was referenced Apr 8, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.7
Development

Successfully merging this pull request may close these issues.

Single selects reopen after selection in 4.0.6
2 participants
@Ferroin @kevin-brown