prevent infinite loop between SelectOnClose and CloseOnSelect #3751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzellman
pushed a commit
to tzellman/select2
that referenced
this pull request
Feb 2, 2016
This fixes an infinite loop that used to be caused when both `closeOnSelect` and `selectOnClose` used to be combined, because they both were listening to events triggered by the other one. The problem was that `selectOnClose` was triggering `select` events for data objects which had already been selected. This problem was solved by checking if the data object was already selected before trying to select it again. This closes select2#3751. This closes select2#3169.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution for #3169, based on @gmitra's suggestion.
I made an attempt to write tests for this, but I'm not terribly familiar with the select2 code base, how the decorators work under the hood, or exactly how things should be pieced together in the unit test, so I had some trouble with it. Strangely, I couldn't even get the test to reproduce the original issue (the infinite loop), so there's something pretty wrong with my test draft.
You can see my first attempt at the tests here: select2:master...ianawilson:select-on-close-loop-tests
If anyone is interested to help me figure out and fix the unit tests, I'd be happy to get those in here and working.