Do you feel like being able to add two unit tests? Search for where the current tests on numbers and groups are.

• one that would try to parse a number from 123,, 123,a
• one that would parse the example you provided in the issue

And also revert the formatting change after the if?

Also note that this change is breaking some tests

Sure, I will add the tests. As for the existing tests failing - it is necessary to look what is wrong with the test or with expressions, or maybe even add some policy, because the example I provided is clearly valid.

Here is a test that fails after your changes:

Assert.Equal((decimal)123456, Literals.Number<decimal>(NumberOptions.Any, groupSeparator: '|').Parse("123|456"));

Here is a test that fails after your changes:

Assert.Equal((decimal)123456, Literals.Number<decimal>(NumberOptions.Any, groupSeparator: '|').Parse("123|456"));

yes, thank you, I see what I have missed. Fixing this now. All the tests are passing, and I am to add some more.

I have made the necessary changes and additions.

Could you remove the restriction for me to edit your PRs? There should be a setting in your fork, and the setting usually allows repos owner to edit PRs by default. That allows me to contribute to it.

@sebastienros I feel ashamed, but I cannot find a corresponding setting within the fork. ChatGPT tells me that this should be a setting for this specific pull request, and if it is missing, this may be because of the pull request settings. If you tell me what you want to modify, I can amend my branch and this pull request, or close this request and try to create a new one with different settings. I have added you to the writers for my fork (just hoping that this may help). I am sorry for the hassle, I am not used to GitHub.

There should be a checkbox on the right side navigation of this page:

There should be a checkbox on the right side navigation of this page:

Thank you for the example. This is something ChatGPT suggested as well, but there is nothing displayed for me below the "participants" section, i.e., there is no such option there. Possibly, this is because the pull request was created with too restrictive settings, or possibly because the fork belongs to an organization of mine, not to my personal profile.

Because this PR is submitted from a repository under an organization, edits from upstream maintainers is always disabled.

https://github.com/orgs/community/discussions/5634

@sebastienros This fix needs more work and tests ... I am working on this problem further now and will update the PR. I am sorry for the restrictions problems.

Thank you!