Introduce cancellation token #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
approved these changes
Apr 7, 2025
sebastienros
reviewed
May 5, 2025
| @@ -1,5 +1,6 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <ItemGroup> | |||
| <PackageReference Include="Meziantou.Analyzer" /> | |||
There was a problem hiding this comment.
Could probably have been a <GlobalPackageReference Include="Meziantou.Analyzer" Version="2.0.177" /> so it's applied everywhere automatically
sebastienros
approved these changes
May 5, 2025
|
Is there a reason why this has not been merged? |
1 task
This was referenced Jul 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a cancellation token property on the async methods.
It flows this cancellation token to the underlying library, rather than trying to manage it, itself.
So
CancelAsyncbehaviour remains the same.Will add some tests tomorrow, just wanted to see how whether the current tests pass.
I added the Meziantou.Analyzer package, as it has a useful anaylzer as to whether all the cancellation tokens have been passed to all the methods that support them. Had to fix a few other things it suggested, and ignore a bunch of other warnings.