filer: remove filer support for image resizing #7057
Conversation
fix #6544 only volume server still support it
There was a problem hiding this comment.
Summary of Changes
Hello @chrislusf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request streamlines the architecture by removing image resizing capabilities from the filer component. The intent is to consolidate this functionality solely within the volume server, aligning with a more focused responsibility for each service. This change simplifies the filer's codebase and clarifies the system's image processing flow.
Highlights
- Image Resizing Responsibility: The filer component no longer supports on-the-fly image resizing. This functionality, previously handled within the
GetOrHeadHandlerinweed/server/filer_server_handlers_read.go, has been removed. This change centralizes image resizing to the volume server, as stated in the PR description. - Code Cleanup and Dependencies: Unused imports (
bytes,mem,images) that were associated with the removed image resizing logic have been cleaned up fromweed/server/filer_server_handlers_read.go, reducing the file's dependencies.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request removes the image resizing functionality from the filer server. The change is clean, focused, and correctly removes the resizing logic and its associated imports from weed/server/filer_server_handlers_read.go.
This simplification of the filer's responsibilities is a good architectural improvement. The code changes are straightforward and I did not find any issues of medium or higher severity in this pull request.
In order to prevent image resizing attempts causing memory issue, filer needs to remove the support for image resizing. Only volume server still support it.
fix #6544
It is not a good idea to resize image on filer level anyway.