implement PubObjectRetention and WORM #6969

chrislusf · 2025-07-12T09:15:40Z

What problem are we solving?

need PubObjectRetention and WORM

How are we solving the problem?

implement

How is the PR tested?

Checks

I have added unit tests if possible.
I will add related wiki document changes and link to this PR after merging.

This reverts commit 6736434.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

This PR implements S3 Object Retention (GOVERNANCE and COMPLIANCE modes), Legal Hold, and legacy WORM support across the SeaweedFS S3 API, including new error codes, routes, handlers, core logic, and end-to-end tests.

Added new S3 API error codes for object lock, retention, and legal hold.
Registered and implemented HTTP routes and handlers for Put/Get Object Retention, Legal Hold, and bucket-level ObjectLockConfiguration.
Added parsing, validation, and enforcement logic in core code, plus comprehensive unit and integration tests under test/s3/retention and updated CI to run them.

Reviewed Changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
weed/s3api/s3err/s3api_errors.go	Added `ErrNoSuchObjectLockConfiguration` and `ErrNoSuchObjectLegalHold` codes and mappings
weed/s3api/s3api_server.go	Registered routes for retention, legal hold, and bucket-level lock configuration
weed/s3api/s3api_object_retention.go	Core parsing, validation, and metadata manipulation for retention and legal hold
weed/s3api/s3api_object_handlers_retention.go	Implemented HTTP handlers for Put/Get Object Retention & Legal Hold
weed/s3api/s3api_object_handlers_delete.go	Enforced retention and bypass-governance checks in single and bulk deletes
test/s3/retention	Added unit tests for parsing/validation and integration tests for WORM compatibility
.github/workflows/s3-versioning-tests.yml	Extended CI workflow to include quick and comprehensive retention tests

Copilot · 2025-07-13T04:55:14Z

weed/s3api/s3api_object_handlers_delete.go

-					Code:    "",
-					Message: err.Error(),
-					Key:     object.ObjectName,
+					Code:      "",


When appending DeleteError for unexpected failures, the Code field is empty. Populate it with the appropriate S3 API error code (e.g., s3err.GetAPIError(s3err.ErrInternalError).Code or the access denied code) so clients receive a valid in the error response.
Suggested change Code: "", Code: s3err.GetAPIError(s3err.ErrInternalError).Code,

Copilot · 2025-07-13T04:55:14Z

weed/s3api/s3api_object_handlers_skip.go

@@ -4,7 +4,7 @@ import (
 	"net/http"
 )



[nitpick] The skip-handlers file has been trimmed to only ACL stubs. Consider updating the file header comment or renaming it to clearly reflect that it now solely provides ACL handler stubs for better maintainability.

Suggested change

// This file contains stub implementations for ACL-related handlers in the S3 API.

// These handlers currently return HTTP 204 No Content responses.

implement PubObjectRetention and WORM

d86bf96

chrislusf requested a review from Copilot July 12, 2025 09:15

This comment was marked as outdated.

Sign in to view

chrislusf added 4 commits July 12, 2025 02:40

Update s3_worm_integration_test.go

6314919

avoid previous buckets

be3e324

Update s3-versioning-tests.yml

4bfb4ec

address comments

e0fcd74

chrislusf requested a review from Copilot July 12, 2025 16:43

This comment was marked as outdated.

Sign in to view

address comments

a67dc2e

chrislusf requested a review from Copilot July 12, 2025 17:48

This comment was marked as outdated.

Sign in to view

chrislusf added 2 commits July 12, 2025 11:24

rename to ExtObjectLockModeKey

2700197

only checkObjectLockPermissions if versioningEnabled

b9b480e

chrislusf requested a review from Copilot July 12, 2025 18:58

This comment was marked as outdated.

Sign in to view

chrislusf added 4 commits July 12, 2025 12:10

address comments

638715e

comments

6736434

Revert "comments"

a72f8b2

This reverts commit 6736434.

Update s3api_object_handlers_skip.go

38d89e5

chrislusf requested a review from Copilot July 12, 2025 19:14

This comment was marked as outdated.

Sign in to view

Update s3api_object_retention_test.go

0ce3ccc

chrislusf requested a review from Copilot July 12, 2025 19:39

This comment was marked as outdated.

Sign in to view

add version id to ObjectIdentifier

450af45

chrislusf requested a review from Copilot July 12, 2025 19:54

This comment was marked as outdated.

Sign in to view

address comments

ce5ffe5

chrislusf requested a review from Copilot July 12, 2025 20:33

This comment was marked as outdated.

Sign in to view

address comments

a5890eb

chrislusf requested a review from Copilot July 12, 2025 21:00

This comment was marked as outdated.

Sign in to view

add version id to the error

0bfd695

chrislusf requested a review from Copilot July 12, 2025 21:10

This comment was marked as outdated.

Sign in to view

chrislusf and others added 4 commits July 12, 2025 14:12

Update weed/s3api/s3api_object_retention_test.go

fdabb50

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update weed/s3api/s3api_object_retention.go

7e834fb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

constants

5cbc028

fix comments

53773b4

chrislusf requested a review from Copilot July 12, 2025 21:36

This comment was marked as outdated.

Sign in to view

address comments

5a26f88

chrislusf requested a review from Copilot July 13, 2025 02:48

This comment was marked as outdated.

Sign in to view

address comment

7538869

chrislusf requested a review from Copilot July 13, 2025 02:53

This comment was marked as outdated.

Sign in to view

chrislusf added 3 commits July 12, 2025 20:18

refactor out handleObjectLockAvailabilityCheck

487e667

errors.Is ErrBucketNotFound

daad789

better error checking

8944d62

chrislusf requested a review from Copilot July 13, 2025 03:31

This comment was marked as outdated.

Sign in to view

address comments

4d351f8

chrislusf requested a review from Copilot July 13, 2025 04:51

Copilot AI reviewed Jul 13, 2025

View reviewed changes

chrislusf merged commit 1549ee2 into master Jul 13, 2025
14 checks passed

chrislusf deleted the implement-PubObjectRetention-and-WORM branch July 13, 2025 04:58

chrislusf mentioned this pull request Jul 13, 2025

worm grace period and retention time support #6404

Merged

2 tasks

	Code: "",
	Code: s3err.GetAPIError(s3err.ErrInternalError).Code,



	// This file contains stub implementations for ACL-related handlers in the S3 API.
	// These handlers currently return HTTP 204 No Content responses.

Uh oh!

implement PubObjectRetention and WORM #6969

implement PubObjectRetention and WORM #6969

Uh oh!

Conversation

chrislusf commented Jul 12, 2025

What problem are we solving?

How are we solving the problem?

How is the PR tested?

Checks

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!