[volume] refactor and add metrics for flight upload and download data limit condition #6920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrislusf
reviewed
Jun 24, 2025
chrislusf
reviewed
Jun 24, 2025
chrislusf
reviewed
Jun 24, 2025
* updated logging methods for stores * updated logging methods for stores * updated logging methods for filer * updated logging methods for uploader and http_util * updated logging methods for weed server --------- Co-authored-by: akosov <a.kosov@kryptonite.ru>
* fix flaky lock ring test * add more tests
233683d to
3c5dd7d
Compare
chrislusf
reviewed
Jun 26, 2025
|
the logic to handle limits is pretty complicated and worth some more refactoring. |
refactoring affected avoiding long queries getting stuck and marking queries on the client side |
|
attempted a refactoring. please help to review and test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
It seems that the concurrent Downloads Limit parameter excessively blocks read requests.
Since the limit is set at the maximum disk speed, blocking occurs, and the disk is not loaded, this is possible when reading is actually done from the page cache and perhaps the actual disk utilization should be taken into account
How are we solving the problem?
In any case, I would like to monitor the inFlightDownloadSize and inFlightUploadSize size metrics
in order to select the optimal size for a specific disk
How is the PR tested?
Checks