Fix url scheme using for forwarded request with changed proto #6884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
Correct signature calculation in case of proxied request with changed protocol (https -> http for example), more in
#6839
How are we solving the problem?
Taking into account
X-Forwarded-Protoheader for host extraction in auth_signature_v4.goHow is the PR tested?
I've builded a local image and deployed it into my k3s cluster where I'm using seaweedfs hidden after traefik proxy (https->http).
Then I've checked with tcpdump that recevied request is correct and checked seaweedfs logs, assuring that the default port is not added for https scheme
Checks