fix(filer): add missing return after KvDelete in KvPut with empty value #6846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
When KvPut receives an empty value, it should delete the key and return immediately
Previously, the function would call KvDelete but then continue execution and call KvPut with the empty value, recreating the entry that was just deleted
How are we solving the problem?
Added missing return statement after successful KvDelete operation
How is the PR tested?
Manual testing with grpcurl commands sending empty values to
KvPutgrpcurl -plaintext -d '{"key":"dGVzdGtleQ==", "value":""}' localhost:18888 filer_pb.SeaweedFiler/KvPutVerified that keys are properly deleted and not recreated
Checks