Skip to content

Conversation

ARibster
Copy link
Contributor

@ARibster ARibster commented May 5, 2025

What problem are we solving?

Addendum to issue #6733
While analyzing the issue regarding the idle Timeout parameter (#6746) I noticed that, to keep consistency, it would be necessary to have a “s3.ip.bind” command line parameter in the filer.go as well.

How are we solving the problem?

add “s3.ip.bind” to filer.go using "ip.bind" as default.

How is the PR tested?

weed.exe filer -defaultStoreDir=".\data" -ip="127.0.0.1" -master="127.0.0.1:9333" -s3 -s3.cert.file="certs\public.crt" -s3.key.file="certs\private.key" -s3.config=".\s3.config" -s3.idleTimeout=30

process PID protocol local address local port state
weed.exe 26404 TCP 127.0.0.1 8888 LISTEN
weed.exe 26404 TCP 127.0.0.1 8333 LISTEN
weed.exe 26404 TCP 127.0.0.1 18888 LISTEN
weed.exe 26404 TCP 127.0.0.1 18333 LISTEN

weed.exe filer -defaultStoreDir=".\data" -ip="127.0.0.1" -master="127.0.0.1:9333" -s3 -s3.cert.file="certs\public.crt" -s3.key.file="certs\private.key" -s3.config=".\s3.config" -s3.idleTimeout=30 -s3.ip.bind="0.0.0.0"

process PID protocol local address local port state
weed.exe 37664 TCP 127.0.0.1 8888 LISTEN
weed.exe 37664 TCP 127.0.0.1 18888 LISTEN
weed.exe 37664 TCP 0.0.0.0 8333 LISTEN
weed.exe 37664 TCP 0.0.0.0 18333 LISTEN
weed.exe 37664 TCP :: 8333 LISTEN
weed.exe 37664 TCP :: 18333 LISTEN

weed.exe filer -defaultStoreDir=".\data" -ip="127.0.0.1" -ip.bind="0.0.0.0" -master="127.0.0.1:9333" -s3 -s3.cert.file="certs\public.crt" -s3.key.file="certs\private.key" -s3.config=".\s3.config" -s3.idleTimeout=30

process PID protocol local address local port state
weed.exe 70184 TCP 0.0.0.0 8333 LISTEN
weed.exe 70184 TCP 0.0.0.0 8888 LISTEN
weed.exe 70184 TCP 0.0.0.0 18333 LISTEN
weed.exe 70184 TCP 0.0.0.0 18888 LISTEN
weed.exe 70184 TCP :: 8333 LISTEN
weed.exe 70184 TCP :: 8888 LISTEN
weed.exe 70184 TCP :: 18333 LISTEN
weed.exe 70184 TCP :: 18888 LISTEN

Checks

  • I have added unit tests if possible.
  • I will add related wiki document changes and link to this PR after merging.

@chrislusf chrislusf merged commit a2c5510 into seaweedfs:master May 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants