Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
Addendum to issue #6733
While analyzing the issue regarding the idle Timeout parameter (#6746) I noticed that, to keep consistency, it would be necessary to have a “s3.ip.bind” command line parameter in the filer.go as well.
How are we solving the problem?
add “s3.ip.bind” to filer.go using "ip.bind" as default.
How is the PR tested?
weed.exe filer -defaultStoreDir=".\data" -ip="127.0.0.1" -master="127.0.0.1:9333" -s3 -s3.cert.file="certs\public.crt" -s3.key.file="certs\private.key" -s3.config=".\s3.config" -s3.idleTimeout=30
process PID protocol local address local port state
weed.exe 26404 TCP 127.0.0.1 8888 LISTEN
weed.exe 26404 TCP 127.0.0.1 8333 LISTEN
weed.exe 26404 TCP 127.0.0.1 18888 LISTEN
weed.exe 26404 TCP 127.0.0.1 18333 LISTEN
weed.exe filer -defaultStoreDir=".\data" -ip="127.0.0.1" -master="127.0.0.1:9333" -s3 -s3.cert.file="certs\public.crt" -s3.key.file="certs\private.key" -s3.config=".\s3.config" -s3.idleTimeout=30 -s3.ip.bind="0.0.0.0"
process PID protocol local address local port state
weed.exe 37664 TCP 127.0.0.1 8888 LISTEN
weed.exe 37664 TCP 127.0.0.1 18888 LISTEN
weed.exe 37664 TCP 0.0.0.0 8333 LISTEN
weed.exe 37664 TCP 0.0.0.0 18333 LISTEN
weed.exe 37664 TCP :: 8333 LISTEN
weed.exe 37664 TCP :: 18333 LISTEN
weed.exe filer -defaultStoreDir=".\data" -ip="127.0.0.1" -ip.bind="0.0.0.0" -master="127.0.0.1:9333" -s3 -s3.cert.file="certs\public.crt" -s3.key.file="certs\private.key" -s3.config=".\s3.config" -s3.idleTimeout=30
process PID protocol local address local port state
weed.exe 70184 TCP 0.0.0.0 8333 LISTEN
weed.exe 70184 TCP 0.0.0.0 8888 LISTEN
weed.exe 70184 TCP 0.0.0.0 18333 LISTEN
weed.exe 70184 TCP 0.0.0.0 18888 LISTEN
weed.exe 70184 TCP :: 8333 LISTEN
weed.exe 70184 TCP :: 8888 LISTEN
weed.exe 70184 TCP :: 18333 LISTEN
weed.exe 70184 TCP :: 18888 LISTEN
Checks