Skip to content

Conversation

seapagan
Copy link
Owner

@seapagan seapagan commented Dec 18, 2023

Merging early to fix test failures caused by misuse of pyfakefs library

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan seapagan added the tests label Dec 18, 2023
@seapagan seapagan self-assigned this Dec 18, 2023
@seapagan seapagan changed the base branch from main to develop December 18, 2023 13:14
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (33f2653) 90.93% compared to head (f17ed4b) 92.85%.
Report is 3 commits behind head on develop.

❗ Current head f17ed4b differs from pull request most recent head 2e48660. Consider uploading reports for the commit 2e48660 to get more accurate results

Files Patch % Lines
app/commands/custom.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #313      +/-   ##
===========================================
+ Coverage    90.93%   92.85%   +1.91%     
===========================================
  Files           30       30              
  Lines          894      896       +2     
===========================================
+ Hits           813      832      +19     
+ Misses          81       64      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
@seapagan seapagan merged commit 0c4cbec into develop Dec 19, 2023
@seapagan seapagan deleted the more_testing branch December 19, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant