Skip to content

Conversation

jeparlefrancais
Copy link
Contributor

@jeparlefrancais jeparlefrancais commented Aug 8, 2025

Closes #171

There can be multiple reasons why a new require path can't be generated from a Rojo sourcemap when using the roblox require mode.

This PR adds a few checks to specialize the error message and provide more information about why a require couldn't be converted.

  • add entry to the changelog

Copy link

github-actions bot commented Aug 8, 2025

Coverage after merging improve-sourcemap-missing-path-warnings into main will be

88.08%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src/rules/convert_require
   roblox_require_mode.rs49.69%100%75%48.37%106–109, 111–114, 118–120, 124–127, 131, 134–136, 138, 144–145, 178–185, 188–196, 200, 205–209, 212, 216–221, 224–231, 46–47, 61–68, 78–80, 92, 94–96
   rojo_sourcemap.rs98.10%100%96.67%98.25%119–121, 159, 93

@jeparlefrancais jeparlefrancais merged commit 65ce18f into main Aug 8, 2025
6 checks passed
@jeparlefrancais jeparlefrancais deleted the improve-sourcemap-missing-path-warnings branch August 8, 2025 21:21
@jeparlefrancais jeparlefrancais mentioned this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading convert require warning
1 participant