Skip to content

Fix missing trailing commas when writing table types #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2025
Merged

Fix missing trailing commas when writing table types #293

merged 2 commits into from
Aug 8, 2025

Conversation

jeparlefrancais
Copy link
Contributor

@jeparlefrancais jeparlefrancais commented Aug 8, 2025 •
edited
Loading

Closes #284

This fixes a bug when using the default retain-lines generator. It will now preserve the trailing comma tokens when writing back the table type node.

  • add entry to the changelog

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2025

Coverage after merging fix-trailing-missing-comma-in-table-type into main will be

88.13%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src/generator
   mod.rs98.66%100%100%98.54%389, 405, 409
   token_based.rs92.18%100%94.68%91.94%1014–1015, 1029–1031, 1054–1055, 1064–1066, 1085–1086, 1095–1097, 1148–1153, 130, 1307, 131, 1377, 1414–1422, 147–148, 1498–1507, 1532–1534, 1566–1575, 160–161, 1619, 1677, 182–183, 203–205, 2133–2134, 2160–2164, 2193–2197, 2417, 2421, 2434, 245, 297–301, 371–372, 378, 390, 450–451, 473–474, 490–491, 533, 621–622, 655–656, 724–725, 766–767, 80, 808–812, 829, 851–853, 917–918, 927–928, 935, 950, 955–959, 978–979, 992–993

@jeparlefrancais jeparlefrancais merged commit 8a216e0 into main Aug 8, 2025
6 checks passed
@jeparlefrancais jeparlefrancais deleted the fix-trailing-missing-comma-in-table-type branch August 8, 2025 20:36
@jeparlefrancais jeparlefrancais mentioned this pull request Aug 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trailing commas in Luau types are unexpectedly stripped
1 participant
@jeparlefrancais