Skip to content

Fix malformed decimal escape sequences preceeding a digit #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2025
Merged

Fix malformed decimal escape sequences preceeding a digit #292

merged 2 commits into from
Aug 8, 2025

Conversation

jeparlefrancais
Copy link
Contributor

@jeparlefrancais jeparlefrancais commented Aug 8, 2025 •
edited
Loading

Closes #286 Closes #291

This PR fixes issues where darklua generated strings with decimal escapes (like "\1") before ascii digits.

  • add entry to the changelog

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2025

Coverage after merging fix-malformed-decimal-escape into main will be

88.13%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src/generator
   utils.rs91.18%100%93.94%90.88%139, 33–34, 341, 35, 355–356, 37, 39, 390–394, 431–439, 63, 73, 83

@jeparlefrancais jeparlefrancais merged commit 59c9adc into main Aug 8, 2025
6 checks passed
@jeparlefrancais jeparlefrancais deleted the fix-malformed-decimal-escape branch August 8, 2025 19:55
@jeparlefrancais jeparlefrancais mentioned this pull request Aug 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Darklua can generate malformed escape sequences A dense generator does not convert decimal escape sequences correctly
1 participant
@jeparlefrancais