Skip to content

Fix remove_assertions rule #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 22, 2024
Merged

Fix remove_assertions rule #229

merged 4 commits into from
Nov 22, 2024

Conversation

jeparlefrancais
Copy link
Contributor

@jeparlefrancais jeparlefrancais commented Nov 22, 2024 •
edited
Loading

Closes #189

Fix the remove_assertions rule to make sure that the assert calls return their arguments.

  • add entry to the changelog

@github-actions GitHub Actions
Copy link

Coverage after merging fix-remove-assertions into main will be

86.04%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src/rules
   remove_assertions.rs97.17%100%100%96.77%40, 52
   remove_call_match.rs69.23%100%80%67.97%100–102, 104–113, 115–118, 123, 125, 14–19, 190–191, 193, 20, 22–24, 51–53, 93–94, 96–99
   remove_debug_profiling.rs97.40%100%100%97.01%52

@jeparlefrancais jeparlefrancais merged commit bfab269 into main Nov 22, 2024
6 checks passed
@jeparlefrancais jeparlefrancais deleted the fix-remove-assertions branch November 22, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove_assertions changes return value when used in a call expression
1 participant
@jeparlefrancais