This repository was archived by the owner on Sep 9, 2024. It is now read-only.
Fix Recursion Error for Derived Classes of @typic.klass
#186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lizing or selecting the appropriate field iterator.
Codecov Report
@@ Coverage Diff @@
## main #186 +/- ##
=======================================
Coverage 94.98% 94.99%
=======================================
Files 37 37
Lines 4169 4172 +3
Branches 582 582
=======================================
+ Hits 3960 3963 +3
Misses 129 129
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived classes of a
typic.klassobject were improperly recognized as a simple Iterable.This caused a recursion error when attempting to serialize these objects, since the
__iter__magic method relies upon the iterator factory, but the iterator factory simply called the__iter__magic method.Resolves #185