Add new rule for Slowloris Attack #809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 29, 2022
ccojocar
approved these changes
Apr 29, 2022
|
@yunwei37 Thanks for this contribution! Please could you fix the lint warning? |
This patch detects if ReadHeaderTimeout is configured in the http.Server to prevent a potential Slowloris Attack.
|
@ccojocar Thank you very much for the review! The lint warning should be fixed now. |
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
==========================================
+ Coverage 74.20% 74.37% +0.16%
==========================================
Files 48 49 +1
Lines 3059 3091 +32
==========================================
+ Hits 2270 2299 +29
- Misses 725 727 +2
- Partials 64 65 +1
Continue to review full report at Codecov.
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #807
Hi! This PR add a new rule to detect if ReadHeaderTimeout is configured in the http.Server. If it's not configured, an issue will be reported.
The rule is mapped to CWE-400: Uncontrolled Resource Consumption, I've used google to search "cwe Slowloris Attack", and it came out this....I'm new to the CWE set so I'm not quite sure about that.