Add support for Makefile variable pattern $(VARIABLE) in database-connection-string rule #1191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Makefile variable pattern
$(VARIABLE)
in the@secretlint/secretlint-rule-database-connection-string
rule to improve compatibility with Make-based projects.Problem
The database-connection-string rule was flagging legitimate Makefile variables as secrets. For example, this common Makefile pattern would trigger false positives:
The
isVariableLikeString
function only supported these variable patterns:${var}
- shell/bash variables{{var}}
- template variables like handlebars{var}
- generic template variables%VAR%
- Windows environment variables$VAR
- simple shell variablesSolution
Added the regex pattern
/\$\([^)]{1,50}\)/
to thevariablePatterns
array inisVariableLikeString
function to recognize Makefile variable syntax$(VAR)
.The pattern:
$(
at the start)
)
at the endTesting
Added comprehensive test cases showing that database connection strings with Makefile variables are properly ignored while real credentials are still detected:
All existing tests continue to pass, ensuring no regression in functionality.
Fixes #1190.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.