feat: Add patterns array support to @secretlint/secretlint-rule-pattern #1186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for specifying multiple patterns as an array in
@secretlint/secretlint-rule-pattern
. The newpatterns
field allows grouping related regex patterns into a single rule configuration, improving maintainability and readability.What's Changed
patterns
array field that accepts multiple regex patternspattern
field (soft deprecation with backward compatibility)patterns
andpattern
fieldscollectPatterns()
functionKey Changes
src/index.ts
:patterns?: string[]
field toPatternType
interfacecollectPatterns()
function for cleaner pattern resolution logicpattern
fieldREADME.md
:patterns
arraypatterns
formatUsage Example
Before (Multiple separate rules)
After (Single rule with multiple patterns)
Test Plan
patterns
array correctly detects multiple patternspattern
field continues to work (backward compatibility)patterns
andpattern
throws appropriate errorfilePathGlobs
works correctly with newpatterns
arrayBreaking Changes
patterns
andpattern
fields together now throws an error. Users must choose one or the other.Additional Notes
pattern
field remains functional but is now deprecatedfilePathGlobs
option🤖 Generated with Claude Code