refactor(types): migrate from tsd to vitest for type testing #1169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace tsd with vitest for type checking to reduce tooling complexity. - Update type test file to use vitest's expectTypeOf API - Rename test file from .type-test.ts to .test-d.ts (vitest convention) - Add vitest.config.ts for @secretlint/types package - Remove exclusion of type tests from root vitest config - Update package.json to use vitest instead of tsd Fixes #1168 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
mrazauskas
reviewed
Aug 15, 2025
| test: { | ||
| typecheck: { | ||
| enabled: true, | ||
| include: ["test/**/*.test-d.ts"], |
There was a problem hiding this comment.
To draw your attention, current setup does not work. Try this:
Suggested change
| include: ["test/**/*.test-d.ts"], | |
| include: ["test/**/*.test-d.ts"], | |
| tsconfig: "./tsconfig.test.json" |
Or open the test file in IDE and you will see an error:
Vitest does not see this problem, because of instead tsconfig.test.json it uses tsconfig.json that does not include the test files. In other words, it runs tsc --noEmit -p tsconfig.json instead of tsc --noEmit -p tsconfig.test.json.
The alarming part for me is that a test file name is actually included in the report of the test run.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
expectTypeOfAPI.type-test.tsto.test-d.ts(vitest convention)Test plan
pnpm testin @secretlint/types package - passespnpm test --filter @secretlint/typesfrom root - passesFixes #1168
🤖 Generated with Claude Code