Add BlockAck Request subtype for addr2 conditional field clause #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1175 +/- ##
==========================================
+ Coverage 83.72% 84.06% +0.34%
==========================================
Files 159 159
Lines 38075 38211 +136
==========================================
+ Hits 31878 32122 +244
+ Misses 6197 6089 -108
|
|
Thanks for your PR. Could you provide an example, and add a unit test in |
|
Not sure what you want as an example. I can provide a .pcap containing a BlockAck Request frame if that's what you mean. |
|
Also, what do you exactly want to include in the regression test? (Sorry, never done it before, but would like to learn). |
|
@adriangranados Please read https://github.com/secdev/scapy/blob/master/CONTRIBUTING.md and get back to us if you have questions |
|
I've added the unit test. Let me know if something else's needed. |
|
That's perfect! Thanks. |
mcoops
added a commit
to mcoops/gopacket
that referenced
this pull request
Mar 20, 2024
Similar to secdev/scapy#1175, only RA (addr1) is being parsed at the moment, update to include the processing of TA (addr2).
mosajjal
pushed a commit
to gopacket/gopacket
that referenced
this pull request
Mar 23, 2024
Similar to secdev/scapy#1175, only RA (addr1) is being parsed at the moment, update to include the processing of TA (addr2).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockAck Request frames have RA (addr1) and TA (addr2) addresses. Only addr1 was being parsed. Also, sorted list of subtypes that have an addr2 field for legibility.