Skip to content

chore(external): remove velovi preprocess functions #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2024
Merged

chore(external): remove velovi preprocess functions #2637

merged 1 commit into from
Mar 29, 2024

Conversation

martinkim0
Copy link
Contributor

BREAKING CHANGE: removes scvi.external.velovi.get_permutation_scores and scvi.external.velovi.preprocess_data based on discussion in #2611

@codecov Codecov
Copy link

codecov bot commented Mar 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (6dedd60) to head (212d5e9).

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2637       +/-   ##
===========================================
+ Coverage   37.67%   88.81%   +51.13%     
===========================================
  Files         159      158        -1     
  Lines       13305    13276       -29     
===========================================
+ Hits         5013    11791     +6778     
+ Misses       8292     1485     -6807
Files Coverage Δ
scvi/external/velovi/__init__.py 100.00% <100.00%> (ø)

... and 112 files with indirect coverage changes

@martinkim0 martinkim0 added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Mar 29, 2024
@martinkim0 martinkim0 merged commit bf81473 into main Mar 29, 2024
@martinkim0 martinkim0 deleted the velovi-preprocess branch March 29, 2024 20:16
meeseeksmachine pushed a commit to meeseeksmachine/scvi-tools that referenced this pull request Mar 29, 2024
@martinkim0 @meeseeksmachine
Backport PR scverse#2637: chore(external): remove velovi preprocess f…
a1baf97 
…unctions
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 29, 2024
Merged
martinkim0 added a commit that referenced this pull request Mar 29, 2024
@meeseeksmachine @martinkim0
Backport PR #2637 on branch 1.2.x (chore(external): remove velovi pre…
07b8762 
…process functions) (#2638)

Backport PR #2637: chore(external): remove velovi preprocess functions

Co-authored-by: Martin Kim <46072231+martinkim0@users.noreply.github.com>
martinkim0 added a commit that referenced this pull request Apr 11, 2024
@martinkim0
docs: remove velovi preprocess from api (#2724)
c837b10 
amends #2637 by also removing the velovi preprocess functions from the
api reference
@martinkim0 martinkim0 mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on-merge: backport to 1.2.x on-merge: backport to 1.2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martinkim0