Skip to content

Conversation

grst
Copy link
Contributor

@grst grst commented Jan 31, 2023

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@grst grst marked this pull request as ready for review February 6, 2023 12:32
@grst grst requested a review from ivirshup February 6, 2023 12:32
@grst
Copy link
Contributor Author

grst commented Feb 6, 2023

Hi @ivirshup,

I now added an example to store ragged ids of transcript ids in adata.varm.
Do you have anything else in mind that you would want me to show in the tutorial?

@ivirshup
Copy link
Member

ivirshup commented Feb 6, 2023

I think that's good. Pretty close to what I was thinking (exon positions for "canonical transcript").

Copy link
Member

@ivirshup ivirshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put the imports under the title and author?

image

@grst
Copy link
Contributor Author

grst commented Feb 9, 2023

done. I also put the warning on the top.

image

@ivirshup ivirshup self-requested a review February 9, 2023 14:57
Copy link
Member

@ivirshup ivirshup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@ivirshup ivirshup merged commit 7f9e52a into master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants