Skip to content

#210 add case annotation display functionality #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 4, 2022
Merged

#210 add case annotation display functionality #215

merged 11 commits into from
Oct 4, 2022

Conversation

andrewtavis
Copy link
Member

@andrewtavis andrewtavis commented Oct 2, 2022 •
edited
Loading

Hey @SaurabhJamadagni! 😊

Firstly, I didn't do the conference, so don't think that I can get to all this while doing something like that at the same time 😄

What this is:

  • Disables the annotations for nouns as they don't do anything (can't be clicked and don't have shadows)
  • Switches the keyboard to the conjugation display when a preposition annotation is pressed
  • Allows for migration through the cases via the left and right buttons in the display
  • Makes the first case shown to the users the first one in the annotation
    • All cases will be able to be seen from the display with the left and right keys though
  • Adds variables for German and Russian case conjugation displays
  • Renaming variables :)

@andrewtavis andrewtavis linked an issue Oct 2, 2022 that may be closed by this pull request
Allow for case conjugation on case annotation button press #210
Closed
2 tasks
@andrewtavis
Copy link
Member Author

efccc13 is just to add the autosuggest files for the other issue so that I can have them available on the current branch for testing as I try to generate them :)

@andrewtavis
Copy link
Member Author

andrewtavis commented Oct 2, 2022 •
edited
Loading

@SaurabhJamadagni, 40c094f is likely gonna be the dumbest commit you ever get from me, and might be because it's late, but easter eggs are fun, so why not? 🐣😊 Let me know what you think 😄

Along with that are some formatting fixes to the ranges as you suggested, as well as adding "Scribe" to the nouns so that it shows up in auto actions :)

SaurabhJamadagni
SaurabhJamadagni approved these changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@SaurabhJamadagni SaurabhJamadagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @andrewtavis! This is such a cool feature! Definitely doesn't feel like a WIP implementation. Also, loved the Scribe easter egg! Looks good to me and didn't experience any bugs during the limited testing I did. Thanks for the review! This was a fun feature to check out. Has me excited 😊

Keyboards/LanguageKeyboards/French/Data/autosuggestions.json
@@ -0,0 +1 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nit picking but extra unnecessary whitespace 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm honestly really excited too 😊 This is gonna be so great :) :)

Thanks for checking it all!

@andrewtavis andrewtavis merged commit f486945 into main Oct 4, 2022
@andrewtavis andrewtavis deleted the feature-210-pronoun-conj branch October 4, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaurabhJamadagni SaurabhJamadagni SaurabhJamadagni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for case conjugation on case annotation button press
3 participants
@andrewtavis @SaurabhJamadagni @helloITdepartment