Hey @andrewtavis, sorry about the numerous commits. I just can't get this one merge conflict to be resolved.

This one conflict is causing a problem. We don't want the .light to be there. So when I take it away in my code the conflict is resolved, but adding the change again as it is needed for the dynamic dark mode it causes a conflict again. Do you know how I could fix this?

Sorry for all the changes to the main branch while you were working on things, @SaurabhJamadagni! I'm a bit unsure on the issue here. As I understand it you want to remove .light from the text color assignment, which would allow either light or dark text colors to be assigned. Why would we add it back in?

For me I would remove the .light in the merge conflict and make it work however it needs to on your end, but I'm potentially oversimplifying things 🤔

Why would we add it back in?

Because if I don't add it back in, it is throwing a merge conflict. I am trying rebasing the branches. Don't know what is going on 😅

Did that work, @SaurabhJamadagni?

All I did was go into the merge conflict UI and remove the original line and the conflict indicators. Sorry if that was an oversimplification though :)

Did that work

I think it did @andrewtavis. Let me know if there are any problems. Currently, it seems like all my changes have gone through 😵‍💫

Will bring the changes in to see if it's all working 😊 Thanks, @SaurabhJamadagni!

All I did was go into the merge conflict UI and remove the original line and the conflict indicators. Sorry if that was an oversimplification though :)

No worries. I think in an attempt to solve it myself, I think I was making conflicting changes myself as well. Seems like its fixed though. Sorry about the bombarding commit messages.

No stress! 😎 Will check this now 🙃

Looks great, @SaurabhJamadagni! Dark mode! 🌔

Minor questions/comments:

• It doesn't look like we're switching the color of the arrows and other icons in the keyboard installation steps? Same for the link text, which should probably be made into a variable?
• If memory serves me, switching the icons in the top right is likely a bit annoying/impossible as the colors are hard coded in PNGs... Do you want to remove them all for now and just put the Go to Settings button from the designs in the top right of the keyboard install flow?
  • Adding back in the icon for the Privacy Policy can just be a part of the work for GSoC :)

Things I'll do after (no stress on this!):

• I think the text on the orange button should be medium and only the first letter should be capitalized.

Thanks for all the work on this, @SaurabhJamadagni!!

It doesn't look like we're switching the color of the arrows and other icons in the keyboard installation steps? Same for the link text, which should probably be made into a variable?

Yes @andrewtavis. The problem with those is that they are images. Thus they don't have any color variable associated with them that can be dynamic. The link colors or symbols like the globe could be changed though with some workaround.

I was also thinking the same. This was more of a temporary solution as I planned to add more image variations that switch on dark mode when we build the full fledged menu. What do you think? We could do the button like in the design file, but currently the entire section itself is like a giant button that takes us to the Settings. So I thought it would be redundant.

I’d say we do need something that indicates that clicking that area of the screen will go to settings, @SaurabhJamadagni, so let’s put the button there and I could potentially switch the full area to a view and put the settings behavior on the Go to Settings button after it’s merged :) For all images just remove them as we want either non-corner icons in the case of GitHub or an inline image in the case of the privacy policy icon. The privacy policy icon can also be a good first issue after this is merged :)

Hey @andrewtavis, could you check these changes that I pushed right now? I added alternate images for the dark mode. Apparently like color sets, we can have alternate sets for images too. Let me know if this can work instead of getting rid of it completely for now.

Thanks, @SaurabhJamadagni! Will check in a moment :)