Skip to content

feat(init): enable skip default provisioners #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

feat(init): enable skip default provisioners #150

merged 1 commit into from
Apr 11, 2025
+22 −15

Conversation

lekaf974
Copy link
Contributor

@lekaf974 lekaf974 commented Apr 6, 2025 •
edited
Loading

Description

add --no-default-provisioner flag

What does this PR do?

This PR fix #148

Before

~/Repos/github/score/score-k8s$ go run cmd/score-k8s/main.go init --file score.yaml 
INFO: Writing new state directory
INFO: Writing new state directory
INFO: Created default provisioners file
INFO: Skipping creation of initial Score file since it already exists
INFO: Read more about the Score specification at https://docs.score.dev/docs/
matthieu@pop-os:~/Repos/github/score/score-k8s$ tree .score-k8s/
.score-k8s/
├── state.yaml
└── zz-default.provisioners.yaml

0 directories, 2 files

After

~/Repos/github/score/score-k8s$ go run cmd/score-k8s/main.go init --file score.yaml --no-default-provisioners
INFO: Writing new state directory
INFO: Writing new state directory
INFO: Skipping creation of default provisioners file since it has been disabled
INFO: Skipping creation of initial Score file since it already exists
INFO: Read more about the Score specification at https://docs.score.dev/docs/
matthieu@pop-os:~/Repos/github/score/score-k8s$ tree .score-k8s/
.score-k8s/
└── state.yaml

0 directories, 1 file

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

@lekaf974
feat(init): enable skip default provisioners
06ce989 
Signed-off-by: lekaf974 <matthieu.evrin@gmail.com>
@lekaf974 lekaf974 mentioned this pull request Apr 6, 2025
Merged
1 task
@lekaf974
Copy link
Contributor Author

lekaf974 commented Apr 6, 2025

@astromechza @mathieu-benoit

@mathieu-benoit mathieu-benoit self-requested a review April 6, 2025 14:47
mathieu-benoit
mathieu-benoit approved these changes Apr 6, 2025
View reviewed changes
Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mathieu-benoit
Copy link
Contributor

@astromechza, quick review on this one please?

@mathieu-benoit mathieu-benoit mentioned this pull request Apr 9, 2025
Closed
astromechza
astromechza approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@astromechza astromechza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lekaf974

@astromechza astromechza merged commit 63e2b1e into score-spec:main Apr 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astromechza astromechza astromechza approved these changes

@mathieu-benoit mathieu-benoit mathieu-benoit approved these changes

Assignees

@lekaf974 lekaf974

Labels
None yet
Projects
KubeCon NA 2025 - Facilitating adoptions and contributions
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature request] support for --no-default-provisioners flag
3 participants
@lekaf974 @mathieu-benoit @astromechza