Skip to content

feat: add provisioners list command #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2025
Merged

feat: add provisioners list command #138

merged 3 commits into from
Apr 7, 2025

Conversation

lekaf974
Copy link
Contributor

Description

What does this PR do?

Add provisioners list command

Fixed #112

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

@lekaf974 lekaf974 changed the title feat: add provisioners list command feat: add provisioners list command [WIP] Mar 11, 2025
@lekaf974
Copy link
Contributor Author

depends on score-spec/score-go#94

@lekaf974 lekaf974 force-pushed the feat/add-provisioners-list-support branch from cb35314 to c2c7d5c Compare March 11, 2025 11:24
@astromechza
Copy link
Member

cc @lekaf974 approved the dependent one score-spec/score-go#94 (review)

lekaf974 added 2 commits April 4, 2025 21:33
@lekaf974
feat: add provisioners list command
285fd1c 
Signed-off-by: lekaf974 <matthieu.evrin@gmail.com>
@lekaf974
feat(provisioners): finalize provisioners list implementation and res…
a54cd84 
…ources update

Signed-off-by: lekaf974 <matthieu.evrin@gmail.com>
@lekaf974 lekaf974 force-pushed the feat/add-provisioners-list-support branch from 02d088c to a54cd84 Compare April 5, 2025 01:33
@lekaf974 lekaf974 marked this pull request as ready for review April 5, 2025 01:34
@lekaf974
chore: add description to default provisioners
993877f 
Signed-off-by: lekaf974 <matthieu.evrin@gmail.com>
@lekaf974
Copy link
Contributor Author

lekaf974 commented Apr 5, 2025

@astromechza @mathieu-benoit ready for review

mathieu-benoit
mathieu-benoit approved these changes Apr 5, 2025
View reviewed changes
Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lekaf974 lekaf974 changed the title feat: add provisioners list command [WIP] feat: add provisioners list command Apr 5, 2025
astromechza
astromechza approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@astromechza astromechza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lekaf974 . this is great 👍

@astromechza astromechza merged commit 7cf0fca into score-spec:main Apr 7, 2025
4 checks passed
@mathieu-benoit mathieu-benoit mentioned this pull request Apr 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astromechza astromechza astromechza approved these changes

@mathieu-benoit mathieu-benoit mathieu-benoit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature request] Add a new score-k8s provisioners list command
3 participants
@lekaf974 @astromechza @mathieu-benoit