feat: update score spec and support files and volumes maps #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e69f69e to
1a66168
Compare
Signed-off-by: Ben Meier <ben.meier@humanitec.com>
1a66168 to
33c6960
Compare
This was referenced Apr 23, 2025
|
This is now successfully integrated and released in both: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the score go library with the latest score spec to support the change from array to object for files.
This was a bit gnarly to update all the tests to use the maps instead of arrays. And the struct generation and validation needed to avoid the 'oneOf' structures in the schema - that's why there's a more significant
jqmodification in the Makefile to pick out the 'object' variant.The critical function for any score implementations is that they must call
ApplyCommonUpgradeTransformsto convert the files array over to a map before running the Validate() functions.You can see now in the generated types, that instead of slices, we get a object for the files and volumes: