Skip to content

feat: add formatter output library #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

feat: add formatter output library #94

merged 1 commit into from
Apr 4, 2025

Conversation

lekaf974
Copy link
Contributor

@lekaf974 lekaf974 commented Mar 8, 2025 •
edited
Loading

Description

Import output formatter library from score-compose implementation to avoid duplication of code between score-xxx cli implementation

What does this PR do?

Relates to score-spec/score-k8s#112

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

@lekaf974
feat: add formatter output library
85b13cf 
Signed-off-by: lekaf974 <matthieu.evrin@gmail.com>
@lekaf974
Copy link
Contributor Author

lekaf974 commented Mar 8, 2025

@mathieu-benoit
@astromechza

@lekaf974
Copy link
Contributor Author

lekaf974 commented Mar 8, 2025

not sure for formatter folder name

@lekaf974 lekaf974 mentioned this pull request Mar 11, 2025
Merged
7 tasks
@mathieu-benoit
Copy link
Contributor

@astromechza, when you have time to review this one please. thanks!

astromechza
astromechza approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@astromechza astromechza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this looks good to me @lekaf974 👍

@mathieu-benoit
Copy link
Contributor

@lekaf974 @astromechza, is this ready to be merged?

@lekaf974
Copy link
Contributor Author

lekaf974 commented Apr 3, 2025

@lekaf974 @astromechza, is this ready to be merged?

I think so

@mathieu-benoit mathieu-benoit merged commit 6b7b181 into score-spec:main Apr 4, 2025
4 checks passed
@mathieu-benoit mathieu-benoit mentioned this pull request Apr 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astromechza astromechza astromechza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lekaf974 @mathieu-benoit @astromechza