Skip to content

Support new files|volumes spec with score-go v1.10.0 #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 29, 2025
Merged

Support new files|volumes spec with score-go v1.10.0 #302

merged 13 commits into from
Apr 29, 2025

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Apr 24, 2025 •
edited
Loading

github.com/score-spec/score-go v1.10.0

score-spec/score-go#103 based on score-spec/spec#123 (comment)

This PR also makes sure that previous/old files|volumes spec is still working while we support the new spec.

Both examples working with this new version (and are not generating any diff with their compose.yaml files):

Old files|volumes spec:

apiVersion: score.dev/v1b1
metadata:
  name: hello-world
containers:
  hello:
    image: .
    files:
      - target: /fileB.txt
        content: |
          I am ${metadata.name}
    volumes:
      - target: /data
        source: ${resources.data}
resources:
  data:
    type: volume

New files|volumes spec:

apiVersion: score.dev/v1b1
metadata:
  name: hello-world
containers:
  hello:
    image: .
    files:
      "/fileB.txt":
        content: |
          I am ${metadata.name}
    volumes:
      "/data":
        source: ${resources.data}
resources:
  data:
    type: volume

@mathieu-benoit
github.com/score-spec/score-go v1.10.0
04165bc 
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
@mathieu-benoit mathieu-benoit marked this pull request as draft April 24, 2025 01:27
@mathieu-benoit mathieu-benoit self-assigned this Apr 24, 2025
astromechza
astromechza reviewed Apr 25, 2025
View reviewed changes
astromechza
astromechza reviewed Apr 25, 2025
View reviewed changes
astromechza
astromechza reviewed Apr 25, 2025
View reviewed changes
astromechza
astromechza reviewed Apr 25, 2025
View reviewed changes
mathieu-benoit and others added 10 commits April 25, 2025 11:08
@mathieu-benoit @astromechza
Update internal/compose/convert.go
46eb071 
Co-authored-by: Ben Meier <1651305+astromechza@users.noreply.github.com>
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
@mathieu-benoit @astromechza
Update internal/compose/convert.go
bee10c9 
Co-authored-by: Ben Meier <1651305+astromechza@users.noreply.github.com>
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
@mathieu-benoit @astromechza
Update internal/compose/convert.go
e7c2004 
Co-authored-by: Ben Meier <1651305+astromechza@users.noreply.github.com>
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
@mathieu-benoit @astromechza
Update internal/compose/convert.go
ca7e985 
Co-authored-by: Ben Meier <1651305+astromechza@users.noreply.github.com>
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
@mathieu-benoit
fix compilation
1b32d71 
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
@mathieu-benoit
FIx compilation
a6936f3 
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
@mathieu-benoit
Merge branch 'main' into score-go-1-10-0
dbc0b3e
@mathieu-benoit
Update examples with new files/volumes spec
558a34c 
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
@mathieu-benoit
Add a Makefile
6b1f0ce 
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
@mathieu-benoit
Add old versus new files/volumes spec unit tests
eb49500 
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
@mathieu-benoit mathieu-benoit marked this pull request as ready for review April 25, 2025 16:33
@mathieu-benoit
Copy link
Contributor Author

I think that's it, ready for your review @astromechza please, thanks!

@mathieu-benoit mathieu-benoit changed the title github.com/score-spec/score-go v1.10.0 Support new files|volumes spec with score-go v1.10.0 Apr 25, 2025
@mathieu-benoit mathieu-benoit mentioned this pull request Apr 27, 2025
Merged
astromechza
astromechza reviewed Apr 29, 2025
View reviewed changes
astromechza
astromechza previously approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@astromechza astromechza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just needs a mod tidy

@mathieu-benoit
go mod tidy
066973f 
Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
@mathieu-benoit mathieu-benoit merged commit 4b03f55 into main Apr 29, 2025
6 checks passed
@mathieu-benoit mathieu-benoit deleted the score-go-1-10-0 branch April 29, 2025 17:42
This was referenced Jun 5, 2025
Merged
Merged
@mathieu-benoit mathieu-benoit mentioned this pull request Jun 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astromechza astromechza astromechza left review comments

Assignees

@mathieu-benoit mathieu-benoit

Labels
None yet
Projects
KubeCon NA 2025 - Facilitating adoptions and contributions
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieu-benoit @astromechza