Skip to content

Conversation

j-bowhay
Copy link
Member

follow up to #20558

seed and rand are scheduled to be removed in this release.

@j-bowhay j-bowhay requested review from larsoner and ilayn as code owners May 22, 2025 13:29
@github-actions github-actions bot added scipy.linalg deprecated Items related to behavior that has been deprecated labels May 22, 2025
@j-bowhay j-bowhay mentioned this pull request May 22, 2025
32 tasks
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Jake! Looks like the tests for rand were fully removed at the time of deprecation.

@lucascolley lucascolley requested review from h-vetinari and removed request for larsoner May 22, 2025 13:39
@lucascolley lucascolley added the needs-release-note a maintainer should add a release note written by a reviewer/author to the wiki label May 22, 2025
@lucascolley lucascolley added this to the 1.17.0 milestone May 22, 2025
@ilayn
Copy link
Member

ilayn commented May 22, 2025

Indeed the seed and the rand was done globally to prime the F77 algorithms and had no other function at the Python layer. Hence the removal. This looks good to me, thanks for handling it.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@j-bowhay j-bowhay merged commit ef89229 into scipy:main May 22, 2025
36 of 39 checks passed
jpmikhail pushed a commit to jpmikhail/scipy that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated Items related to behavior that has been deprecated needs-release-note a maintainer should add a release note written by a reviewer/author to the wiki scipy.linalg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants