Skip to content

ENH: linalg.cossin: add batch support #22197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2024
Merged

ENH: linalg.cossin: add batch support #22197

merged 1 commit into from
Dec 27, 2024

Conversation

mdhaber
Copy link
Contributor

@mdhaber mdhaber commented Dec 27, 2024

Reference issue

Toward gh-21466

What does this implement/fix?

Adds batch support to linalg.cossin.

Additional information

Pretty straightford with the trick for dealing with functions that accept tuples of arrays (see also gh-22192): split into:

  • decorated private function that accepts only separate arrays and
  • public function that accepts tuples, isolates arrays, and calls the private function.

@mdhaber mdhaber added enhancement A new feature or improvement scipy.linalg labels Dec 27, 2024
@mdhaber mdhaber requested a review from j-bowhay December 27, 2024 06:03
@mdhaber mdhaber mentioned this pull request Dec 27, 2024
Open
j-bowhay
j-bowhay reviewed Dec 27, 2024
View reviewed changes
j-bowhay
j-bowhay approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@j-bowhay j-bowhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@j-bowhay j-bowhay merged commit 9220a7a into scipy:main Dec 27, 2024
38 checks passed
@j-bowhay j-bowhay added this to the 1.16.0 milestone Dec 27, 2024
@lucascolley lucascolley added the needs-release-note a maintainer should add a release note written by a reviewer/author to the wiki label Jan 31, 2025
@mdhaber mdhaber removed the needs-release-note a maintainer should add a release note written by a reviewer/author to the wiki label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-bowhay j-bowhay j-bowhay approved these changes

@larsoner larsoner Awaiting requested review from larsoner larsoner is a code owner

@ilayn ilayn Awaiting requested review from ilayn ilayn is a code owner

Assignees
No one assigned
Labels
enhancement A new feature or improvement scipy.linalg
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mdhaber @j-bowhay @lucascolley