TST: ndimage: unskip test_boundary_spline_accuracy for torch
#21282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip cirrus] [skip circle]
|
I believe an alternative to this PR is to use the array_api_compat-wrapped |
|
LGTM assuming CI comes back happy. |
test_boundary_spline_accuracy for torchtest_boundary_spline_accuracy for torch
j-bowhay
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Towards gh-21280
What does this implement/fix?
This test was not written portably in gh-21150. This PR fixes that.
Additional information
Technically we don't need the extra
array_namespacecall forxp.newaxisas it is just an alias forNone, but I figured we may as well use it to write idiomatically.