DEP: signal.{correlate,convolve,lfilter}: deprecate object arrays and longdoubles #21211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c78d938 to
096a563
Compare
j-bowhay
reviewed
Jul 18, 2024
|
+1 from me too. |
5be85f0 to
69bebc4
Compare
j-bowhay
reviewed
Jul 19, 2024
|
I updated the error message to point users to the usable dtypes and added some tests for the deprecation warning (for |
|
... of objects & longdoubles from correlate/convolve and lfilter. Co-authored-by: Jake Bowhay <60778417+j-bowhay@users.noreply.github.com>
Co-authored-by: Jake Bowhay <60778417+j-bowhay@users.noreply.github.com>
[skip cirrus]
[skip cirrus]
9543198 to
424e405
Compare
|
OK, rolled back the float16 deprecation. With the ML (== discourse) thread silent for a month, I think we can land this one unless there are further comments. |
lucascolley
requested changes
Aug 15, 2024
lucascolley
approved these changes
Aug 17, 2024
anushkasuyal
pushed a commit
to anushkasuyal/scipy
that referenced
this pull request
Sep 13, 2024
… longdoubles (scipy#21211) Co-authored-by: Jake Bowhay <60778417+j-bowhay@users.noreply.github.com> Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>
ev-br
added a commit
to ev-br/scipy
that referenced
this pull request
Oct 14, 2024
This is a follow-up to scipygh-21211: we deprecated object arrays as inputs to `lfilter`, but forgot or did not know about `sosfilt`. These two should probably be in sync, hence follow the lfilter deprecation in sosfilt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on the discussion at #20772 (comment), here is proposal to deprecate using object arrays and longdoubles in
scipy.signal.{correlate,convolve,lfilter}.The intended use cases were, judging by tests, dealing with arrays of Decimals. The relevant C code has been there "forever" (since when multipack was a thing), and is very likely buggy since then (cf this comment https://github.com/scipy/scipy/blob/main/scipy/signal/_lfilter.c.in#L679).
Whether these are used in the wild is a tough question to answer. A gut feeling is "not much", and as a data point, we had no complaints when we recently (in the 1.11-1.14 timeframe) removed object and longdouble support in medfilt (#19673 and #18341). So most likely, it won't be a large loss if these are gone.
This PR is currently also removes float16 support. This might be a bit on a too-wide-sweep side, and I'm happy to roll it back. OTOH, the "support" currently seems to be just upcasting to wider float types, so this deprecation might be okay, too.