DEP: stats.find_repeats: deprecate function
#21157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stats.find_repeats: deprecate function
There was a problem hiding this comment.
I guess if you do this you need one more spot patched as below (or with a suppression of the warning, or with replacement by the NumPy equivalent). By the way, what happens for the mstats version of the function if you do this? Does that one get to stay since the mask-related functionality is still unique to SciPy?
--- a/scipy/stats/tests/test_mstats_basic.py
+++ b/scipy/stats/tests/test_mstats_basic.py
@@ -1865,7 +1865,9 @@ class TestCompareWithStats:
xm = np.ma.array(tmp, mask=mask)
x_orig, xm_orig = x.copy(), xm.copy()
- r = stats.find_repeats(x)
+ message = "`scipy.stats.find_repeats` is deprecated..."
+ with pytest.deprecated_call(match=message):
+ r = stats.find_repeats(x)|
|
[docs only] Co-authored-by: Jake Bowhay <60778417+j-bowhay@users.noreply.github.com>
j-bowhay
approved these changes
Jul 18, 2024
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
gh-21077
What does this implement/fix?
The docstring of
find_repeatsmentions:NumPy 1.9 has been available for a while now, and we were not able to find many uses of
find_repeats(gh-21077), so we discussed removing the function rather than adding array API support.Additional information
Needs approval on discuss before merge.