API: stats.{PermutationMethod,BootstrapMethod}: transition to rng (SPEC 7)
#21886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
commented
Nov 13, 2024
mdhaber
commented
Nov 13, 2024
mdhaber
commented
Nov 13, 2024
stats.PermutationMethod: transition to rng (SPEC 7)stats.PermutationMethod: transition to rng (SPEC 7)
mdhaber
commented
Nov 13, 2024
mdhaber
commented
Nov 13, 2024
j-bowhay
reviewed
Nov 15, 2024
j-bowhay
reviewed
Nov 15, 2024
|
Probably not. I re-ran and now the failure is just the one that's in main. |
j-bowhay
approved these changes
Nov 15, 2024
stats.PermutationMethod: transition to rng (SPEC 7)stats.{PermutationMethod,BootstrapMethod}: transition to rng (SPEC 7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Towards gh-21833
What does this implement/fix?
This allows for use of new keyword
rngalongsiderandom_stateinscipy.stats.PermutationMethodto prepare for the deprecation and removal ofrandom_stateand its legacy behavior. This is a little trickier than other similar PRs becauserandom_statewas not only a keyword argument of the initializer but an attribute of thedataclass.Additional information
Ready for review, but leaving as draft before comments. After making any corrections, I'll copy these ideas over to
BootstrapMethod. We might be able to save a few lines by making a private superclass of the two, but it's probably not worth the complexity.